Bump quote to 0.4 #1235
Merged
Bump quote to 0.4 #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
force-pushed
the
quote
branch
2 times, most recently
from
6aca332 to
d3b86a5
Compare
fitzgen
reviewed
Jan 23, 2018
| @@ -18,7 +17,7 @@ impl protocol_SomeProtocol for id { | |||
| } | |||
| unsafe fn protocolClassMethod() { | |||
| msg_send!( | |||
| objc::runtime::Class::get("SomeProtocol").expect("Couldn't find SomeProtocol"), | |||
| objc::runtime::Class::get("SomeProtocol").expect("Couldn\'t find SomeProtocol"), | |||
There was a problem hiding this comment.
Looks like there is too much escaping happening now.
There was a problem hiding this comment.
Nothing I can do about it unfortunately (unless I missed something)
fitzgen
reviewed
Jan 23, 2018
| @@ -3290,7 +3286,7 @@ fn objc_method_codegen( | |||
| let class_name = class_name | |||
| .expect("Generating a class method without class name?") | |||
| .to_owned(); | |||
| let expect_msg = format!("Couldn't find {}", class_name); | |||
| let expect_msg = proc_macro2::Literal::string(&format!("Couldn't find {}", class_name)); | |||
There was a problem hiding this comment.
HUh, I guess proc_macro2 isn't smart about string escaping.
There was a problem hiding this comment.
There was a problem hiding this comment.
|
@bors-servo r+ |
|
📌 Commit 6899c27 has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.