Skip to content

codegen: Don't generate repr(C) for enums. #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Jan 19, 2018

That's only undefined for enums with fields.

Fixes #1224
See also: https://botbot.me/mozilla/rustc/2018-01-19/?msg=95934948&page=2

@emilio
Copy link
Contributor Author

emilio commented Jan 19, 2018

r? @fitzgen or @pepyakin

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this!

@fitzgen
Copy link
Member

fitzgen commented Jan 19, 2018

@bors-servo r+

@bors-servo
Copy link

📌 Commit 15c18d0 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 15c18d0 with merge 918abed...

bors-servo pushed a commit that referenced this pull request Jan 19, 2018
codegen: Don't generate repr(C) for enums.

That's only undefined for enums with fields.

Fixes #1224
See also: https://botbot.me/mozilla/rustc/2018-01-19/?msg=95934948&page=2
@bors-servo
Copy link

💔 Test failed - status-travis

@emilio
Copy link
Contributor Author

emilio commented Jan 19, 2018

@bors-servo r=fitzgen

  • Updated tests in platform-dependent directories

@bors-servo
Copy link

📌 Commit fbb6d6f has been approved by fitzgen

bors-servo pushed a commit that referenced this pull request Jan 19, 2018
codegen: Don't generate repr(C) for enums.

That's only undefined for enums with fields.

Fixes #1224
See also: https://botbot.me/mozilla/rustc/2018-01-19/?msg=95934948&page=2
@bors-servo
Copy link

⌛ Testing commit fbb6d6f with merge 8fa15cc...

@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 8fa15cc to master...

@bors-servo bors-servo merged commit fbb6d6f into rust-lang:master Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants