Make CARGO_PKG_VERSION option_env!, rather than env! #1220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Jan 10, 2018
|
@bors-servo r+ |
|
📌 Commit d302c13 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 10, 2018
Make CARGO_PKG_VERSION option_env!, rather than env! This PR makes the "CARGO_PKG_VERSION" env variable optional, which facilitates crate compilation using tools other than Cargo.
|
💔 Test failed - status-travis |
|
Thanks for the ultra quick turnaround! Is that test failure a flake? |
|
Looks like it... Thanks a lot for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the "CARGO_PKG_VERSION" env variable optional, which facilitates crate compilation using tools other than Cargo.