Clang trunk considers stuff in an anonymous namespace with internal linkage. #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inkage. I think that's right, and the previous behavior was just a bug. Rejigger the tests that show this difference since they aren't testing this in particular, and avoids adding more per-platform tests.
|
@bors-servo r+ |
|
📌 Commit 65a4ca0 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 8, 2018
Clang trunk considers stuff in an anonymous namespace with internal linkage. I think that's right, and the previous behavior was just a bug. Rejigger the tests that show this difference since they aren't testing this in particular, and avoids adding more per-platform tests.
|
💔 Test failed - status-travis |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 9, 2018
Clang trunk considers stuff in an anonymous namespace with internal linkage. I think that's right, and the previous behavior was just a bug. Rejigger the tests that show this difference since they aren't testing this in particular, and avoids adding more per-platform tests.
|
💔 Test failed - status-travis |
|
There are intermittent download failures from llvm.org, but the branch commit is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that's right, and the previous behavior was just a bug.
Rejigger the tests that show this difference since they aren't testing this in
particular, and avoids adding more per-platform tests.