Move self into ir::BindgenContext::gen
#1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`parse_one` was never supposed to be public and it uses a bunch of non-public types as a parameters, so downstream crates wouldn't be able to call it anyways.
pepyakin
reviewed
Oct 12, 2017
src/ir/context.rs
Outdated
| self.in_codegen = false; | ||
| ret | ||
| let ret = cb(&self); | ||
| (ret, self.into()) |
There was a problem hiding this comment.
I dont think I've grasped all the idioms of Rust, but still, this seems quite unusual to me. Maybe it would be better to just use (ret, self.options)?
There was a problem hiding this comment.
Ah! This is from when I was trying to do the conversion inside codegen rather than here, and privacy wouldn't have allowed that. Good eye!
`bindgen` follows a pipeline architecture, and we only ever generate bindings once. By taking ownership of `self`, we can enforce this. We can also remove checks inside `gen` for whether we have resolved type refs or not, since we now know that we haven't because it is guaranteed to only be called the one time.
fitzgen
force-pushed
the
move-self-into-gen
branch
from
6db2c60 to
6f401c5
Compare
|
@bors-servo r=pepyakin |
|
📌 Commit 6f401c5 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 12, 2017
Move `self` into `ir::BindgenContext::gen` Small clean up. See each commit for details. r? @pepyakin
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small clean up. See each commit for details.
r? @pepyakin