Tell LLVM to not mangle names if they're already mangled #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
reviewed
Oct 7, 2017
|
Could you explain about the mangling hack? Edit: |
liranringel
force-pushed
the
disable-mangling-if-link-name-is-specified
branch
from
07d59c8 to
1b6345d
Compare
liranringel
force-pushed
the
disable-mangling-if-link-name-is-specified
branch
from
1b6345d to
f2b30c8
Compare
emilio
approved these changes
Oct 8, 2017
|
@bors-servo r+ |
|
📌 Commit f2b30c8 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 8, 2017
…ecified, r=emilio
Tell LLVM to not mangle names if they're already mangled
LLVM mangles the name by default but functions are already mangled because the `link_name` attribute's value is mangled.
Prefixing the name with `\u{1}` should tell LLVM to not mangle it.
I originally thought it's a bug in rustc, but it was clarified here: rust-lang/rust#45073
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM mangles the name by default but functions are already mangled because the
link_nameattribute's value is mangled.Prefixing the name with
\u{1}should tell LLVM to not mangle it.I originally thought it's a bug in rustc, but it was clarified here: rust-lang/rust#45073