Make bitfields larger than type opaque #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
reviewed
Oct 4, 2017
src/ir/comp.rs
Outdated
| return true | ||
| } | ||
|
|
||
| let has_large_bitfield = self.fields().iter().any(|f| match *f { |
There was a problem hiding this comment.
Nitpick: rather than assigning the bool expression to a variable and then returning the variable, we should return the expression directly.
src/ir/comp.rs
Outdated
| fn is_opaque(&self, _: &BindgenContext, _: &()) -> bool { | ||
| self.has_non_type_template_params | ||
| fn is_opaque(&self, ctx: &BindgenContext, _: &()) -> bool { | ||
| //Early return to avoid extra computation |
There was a problem hiding this comment.
Nitpick: space between // and Early, and a period at the end of the sentence please :)
|
@bors-servo r+ |
|
📌 Commit aa27283 has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fitzgen r?
Fixes #1007 by ensuring that bitfields larger than type will be opaque, ensuring the layout is correct.