Skip to content

Add a CONTRIBUTING.md file #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2016
Merged

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Oct 21, 2016

It provides an overview of how to file a helpful issue and how to run tests.

Fixes #93

r? @emilio

Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks for doing this :)

r=me with one question/comment.

## Filing an Issue <span id="issue"/>

Think you've found a bug? File an issue! To help us understand and reproduce the
issue, provide us with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to provide us? Some issues like #67 are really tricky to minimize :)

Worth commenting here maybe that running with RUST_LOG=bindgen spits a log really helpful for debugging.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oo good thought on the logging

@emilio
Copy link
Contributor

emilio commented Oct 21, 2016

@bors-servo: delegate+

@bors-servo
Copy link

✌️ @fitzgen can now approve this pull request

It provides an overview of how to file a helpful issue and how to run tests.

Fixes rust-lang#93
@fitzgen
Copy link
Member Author

fitzgen commented Oct 21, 2016

@bors-servo r=emilio

@bors-servo
Copy link

📌 Commit 1c9ad3e has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit 1c9ad3e with merge 8f8dc0f...

bors-servo pushed a commit that referenced this pull request Oct 21, 2016
Add a CONTRIBUTING.md file

It provides an overview of how to file a helpful issue and how to run tests.

Fixes #93

r? @emilio
@bors-servo
Copy link

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit 1c9ad3e into rust-lang:master Oct 21, 2016
@fitzgen fitzgen deleted the contributing-md branch October 21, 2016 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants