Some little deriving cleanups #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #1003) made this pull request unmergeable. Please resolve the merge conflicts. |
fitzgen
force-pushed
the
some-little-deriving-cleanups
branch
from
8caaa4a to
dd2a6a2
Compare
pepyakin
reviewed
Sep 20, 2017
| @@ -115,7 +124,7 @@ impl<'ctx> MonotoneFramework for CannotDerivePartialEqOrPartialOrd<'ctx> { | |||
| trace!("constrain: {:?}", id); | |||
|
|
|||
| if self.cannot_derive_partialeq_or_partialord.contains(&id) { | |||
| trace!(" already know it cannot derive PartialEq or PartialOrd"); | |||
| trace!(" already know it cannot derive `PartialEq`/`PartialOrd`"); | |||
There was a problem hiding this comment.
Is it makes sense to put markdownique syntax in logs?
There was a problem hiding this comment.
I like to be consistent :)
| /// | ||
| /// * If T is Array type, `PartialEq` or partialord cannot be derived if the | ||
| /// length of the array is larger than the limit or the type of data the array | ||
| /// contains cannot derive `PartialEq` or partialord. |
There was a problem hiding this comment.
Is partialord intentional or just missed?
Changing "partialeq" and "partialord" into "`PartialEq`" and "`PartialOrd`" where it makes sense.
We were copying it around and it will be easier if it is defined in one place.
Again, this logic was getting copied all over the place, and it is nice to have a single canonical definition.
The whole "should be a no-op" thing isn't really true for all of the traits, especially in the face of black listing. Also further expounded on the differences between the trivial versions and normal versions.
fitzgen
force-pushed
the
some-little-deriving-cleanups
branch
from
dd2a6a2 to
337fbb4
Compare
emilio
approved these changes
Sep 24, 2017
|
@bors-servo r+ |
|
📌 Commit 337fbb4 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 24, 2017
Some little deriving cleanups See each commit for details. r? @emilio
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit for details.
r? @emilio