Add a Builder::blacklist_type method; deprecate Builder::hide_type
#984
Comments
|
Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the If you intend to work on this issue, then add |
|
Hi! I'd like to try implementing this. @highfive: assign me |
|
Hey @alexeyzab! Thanks for your interest in working on this issue. It's now assigned to you! |
alexeyzab
added a commit
to alexeyzab/rust-bindgen
that referenced
this issue
Sep 14, 2017
This deprecates `Builder::hide_type`. Related to rust-lang#984. - [x] Add Builder::blacklist_type, that does the same thing as hide_type - [x] Mark Builder::hide_type as #[deprecated = "Use blacklist_type instead"] - [x] Make hide_type delegate to blacklist_type - [x] Rename the BindgenOptions::hidden_types member to BindgenOptions::blacklisted_types - [x] Rename ir::context::BindgenContext::hidden_by_name to blacklisted_by_name - [x] Rename ir::item::Item::is_hidden to is_blacklisted
bors-servo
pushed a commit
that referenced
this issue
Sep 14, 2017
Add a `Builder::blacklist_type` This deprecates `Builder::hide_type`. Related to #984. - [x] Add Builder::blacklist_type, that does the same thing as hide_type - [x] Mark Builder::hide_type as #[deprecated = "Use blacklist_type instead"] - [x] Make hide_type delegate to blacklist_type - [x] Rename the BindgenOptions::hidden_types member to BindgenOptions::blacklisted_types - [x] Rename ir::context::BindgenContext::hidden_by_name to blacklisted_by_name - [x] Rename ir::item::Item::is_hidden to is_blacklisted r? @fitzgen
|
fixed in #991 |
|
Thanks for the reminder, @tamird ! @alexeyzab, fwiw, if you add "Fixes #12345" in the git commit message, github will automatically close the issue once the relevant PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Currrently, the
--blacklist-typeflag's correspondingBuildermethod isBuilder::hide_type.The naming difference is unnecessary, inconsistent, makes it harder for users to switch from CLI to builder or vice versa, and adds one more thing to remember/know about the code base when developers are reading about hidden or blacklisted things.
We should:
Builder::blacklist_type, that does the same thing ashide_typeBuilder::hide_typeas#[deprecated = "Use blacklist_type instead"]hide_typedelegate toblacklist_typeBindgenOptions::hidden_typesmember toBindgenOptions::blacklisted_typesir::context::BindgenContext::hidden_by_nametoblacklisted_by_nameir::item::Item::is_hiddentois_blacklistedThe text was updated successfully, but these errors were encountered: