Skip to content

Test call-conv-field fails on macOS #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
upsuper opened this issue Mar 20, 2017 · 2 comments
Closed

Test call-conv-field fails on macOS #593

upsuper opened this issue Mar 20, 2017 · 2 comments
Labels

Comments

@upsuper
Copy link
Contributor

upsuper commented Mar 20, 2017

On macOS, I get:

diff --git a/tests/expectations/tests/call-conv-field.rs b/tests/expectations/tests/call-conv-field.rs
index d6aa9e4..7b03961 100644
--- a/tests/expectations/tests/call-conv-field.rs
+++ b/tests/expectations/tests/call-conv-field.rs
@@ -37,6 +37,6 @@ impl Default for JNINativeInterface_ {
     fn default() -> Self { unsafe { ::std::mem::zeroed() } }
 }
 extern "stdcall" {
-    #[link_name = "_bar@0"]
+    #[link_name = "bar@0"]
     pub fn bar();
 }
@emilio
Copy link
Contributor

emilio commented Mar 20, 2017

Yeah, this is known. It's about this bit of code, which assumes host_os == target_os, which isn't true for that test.

@emilio
Copy link
Contributor

emilio commented Apr 22, 2017

I've submitted https://reviews.llvm.org/D32389 to make this fixable.

dtzWill pushed a commit to llvm-mirror/clang that referenced this issue Apr 28, 2017
This allows users to query the target triple and target pointer width, which
would make me able to fix rust-lang/rust-bindgen#593 and
other related bugs in an elegant way (without having to manually parse the
target triple in the command line arguments).

Differential Revision: https://reviews.llvm.org/D32389



git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@301648 91177308-0d34-0410-b5e6-96231b3b80d8
jyknight pushed a commit to jyknight/llvm-monorepo-old1 that referenced this issue Apr 28, 2017
This allows users to query the target triple and target pointer width, which
would make me able to fix rust-lang/rust-bindgen#593 and
other related bugs in an elegant way (without having to manually parse the
target triple in the command line arguments).

Differential Revision: https://reviews.llvm.org/D32389

llvm-svn=301648
spurious pushed a commit to spurious/clang-mirror that referenced this issue Apr 28, 2017
This allows users to query the target triple and target pointer width, which
would make me able to fix rust-lang/rust-bindgen#593 and
other related bugs in an elegant way (without having to manually parse the
target triple in the command line arguments).

Differential Revision: https://reviews.llvm.org/D32389



git-svn-id: http://llvm.org/svn/llvm-project/cfe/trunk@301648 91177308-0d34-0410-b5e6-96231b3b80d8
fitzgen added a commit to fitzgen/rust-bindgen that referenced this issue May 24, 2017
This is a temporary work around for issue rust-lang#593 and this test failing on MacOS
because we don't currently handle when bindgen's target OS is not the same as
the emitted bindings' target OS.
bors-servo pushed a commit that referenced this issue May 25, 2017
Only run call-conv-field.h test on linux

This is a temporary work around for issue #593 and this test failing on MacOS because we don't currently handle when the bindgen executable's target OS is not the same as the emitted bindings' target OS.

r? @emilio
emilio added a commit to emilio/rust-bindgen that referenced this issue Jun 1, 2017
tmfink pushed a commit to tmfink/rust-bindgen that referenced this issue Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants