Skip to content

Automatically allow non_snake_case, non_camel_case_types, non_upper_case_globals #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crumblingstatue opened this issue Mar 6, 2017 · 8 comments
Closed

Automatically allow non_snake_case, non_camel_case_types, non_upper_case_globals #562

crumblingstatue opened this issue Mar 6, 2017 · 8 comments
Labels
C-assigned E-easy help wanted

Comments

@crumblingstatue
Copy link

Bindings generated by bindgen are not expected to follow Rust naming conventions, so it's a reasonable default to automatically add #![allow(non_snake_case, non_camel_case_types, non_upper_case_globals)] to the generated module.
@fitzgen
Copy link
Member

fitzgen commented Mar 6, 2017

See also #373

@highfive
Copy link

highfive commented Mar 6, 2017

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@framlog
Copy link
Contributor

framlog commented Mar 7, 2017

@highfive: assign me

@highfive
Copy link

highfive commented Mar 7, 2017

Hey @framlog! Thanks for your interest in working on this issue. It's now assigned to you!

@framlog framlog mentioned this issue Mar 7, 2017
Merged
bors-servo pushed a commit that referenced this issue Mar 9, 2017
Auto merge of #565 - framlog:master, r=fitzgen
1320efe 
automatically allow non rust naming conventions

+ related issue: #562

I just added those attributes at the root mod. And I'm not sure whether it should be better if we could set this setting in `build.rs`.
This was referenced Mar 12, 2017
Closed
Closed
@jdm
Copy link
Contributor

jdm commented Mar 22, 2017

Have you made any progress, @framlog? Any questions?

@jdm
Copy link
Contributor

jdm commented Mar 22, 2017

Oh, I missed #580.

@framlog
Copy link
Contributor

framlog commented Mar 23, 2017

@jdm It should works imo.

@emilio
Copy link
Contributor

emilio commented Sep 6, 2017

I don't think we should do that given how invasive it is (see #580). Thanks @framlog, though, for coming up with a PR!

@emilio emilio closed this as completed Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned E-easy help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jdm @fitzgen @emilio @crumblingstatue @framlog @highfive