You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This breaks msvc (or really any non-default-target bindings generation):
When llvm/clang is built for the gnu target by default (needed for msvc bindings generation, because it's easier to use those default include paths and let the msvc target get them from $INCLUDE), clang behaves properly:
Skip -isystem stuff if --target is specified, and don't strip leading _ on Windows
The -isystem stuff fixes issue #53.
Stripping leading _ on Windows is weird; it needs to not be stripped on MSVC (leading @), but on gcc at one point it needed to be. But now it no longer does. I don't know. 'cargo test' succeeds with mozjs bindings generated with these fixes.
This breaks msvc (or really any non-default-target bindings generation):
When llvm/clang is built for the gnu target by default (needed for msvc bindings generation, because it's easier to use those default include paths and let the msvc target get them from $INCLUDE), clang behaves properly:
But when rust-bindgen is passed --target=x86_64-pc-win32, it gets:
which then totally breaks the generation.
I'm going to hack around this by skipping the clang-sys isystem stuff (why is it needed?) if --target is specified.
The text was updated successfully, but these errors were encountered: