Skip to content

Support for macro defined string constants #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
azerupi opened this issue Nov 14, 2016 · 3 comments
Closed

Support for macro defined string constants #256

azerupi opened this issue Nov 14, 2016 · 3 comments

Comments

@azerupi
Copy link

azerupi commented Nov 14, 2016

I am trying to make bindings for the OpenFX API and they define some constants using macros:

#define kOfxImageEffectPluginApi "OfxImageEffectPluginAPI"
#define kOfxImageEffectPluginApiVersion 1

Bindgen seems to have no trouble with the numeric constant, but it ignores the string constant. Would it be possible to add support for macro defined string constants?
@emilio
Copy link
Contributor

emilio commented Nov 15, 2016

I guess we can try, I'll take a look :)

@emilio emilio mentioned this issue Nov 15, 2016
Merged
@emilio
Copy link
Contributor

emilio commented Nov 16, 2016

Patch up in #260, with a bunch of other improvements.

@azerupi
Copy link
Author

azerupi commented Nov 16, 2016

That was fast! Thank you :)

bors-servo pushed a commit that referenced this issue Nov 16, 2016
Auto merge of #260 - emilio:macro-str, r=fitzgen
e74acce 
Constant variable improvements.

Fixes #256.

r? @fitzgen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emilio @azerupi