-
Notifications
You must be signed in to change notification settings - Fork 748
clang::Cursor::enum_val_unsigned should return Option<u64> #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Please make a comment here if you intend to work on this issue. Thank you! |
I would like to take a swing at this. |
Sure, thanks for it! :) |
This was referenced Nov 6, 2016
@jcdyer, thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(Similar to #127)
Right now it always returns u64, but the FFI call it makes says
http://clang.llvm.org/doxygen/group__CINDEX__TYPES.html#gaf7cbd4f2d371dd93e8bc997c951a1aef
We shouldn't force callers to check the kind of the cursor, we should do the check ourselves in this function and return an option. This would result in one less foot gun.
I can mentor anyone who'd like to pick up this bug.
The text was updated successfully, but these errors were encountered: