Skip to content

Builder::command_line_flags misgenerates rust target's flag #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fitzgen opened this issue Dec 8, 2017 · 4 comments
Closed

Builder::command_line_flags misgenerates rust target's flag #1182

fitzgen opened this issue Dec 8, 2017 · 4 comments
Labels
C-assigned E-easy help wanted

Comments

@fitzgen
Copy link
Member

fitzgen commented Dec 8, 2017

It should add ["--rust-target", "1.19"] but only adds the second part.

See the command_line_flags method of Builder in src/lib.rs.

There are some tests that can be extended at the bottom of the file.
@highfive
Copy link

highfive commented Dec 8, 2017

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@manaskarekar
Copy link
Contributor

@highfive: assign me

@highfive
Copy link

highfive commented Dec 9, 2017

Hey @manaskarekar! Thanks for your interest in working on this issue. It's now assigned to you!

@manaskarekar manaskarekar mentioned this issue Dec 9, 2017
Merged
bors-servo pushed a commit that referenced this issue Dec 9, 2017
Auto merge of #1186 - manaskarekar:issue-1182, r=emilio
c3ec58c 
Fix command_line_flags mis-generation of rust-target's flags.

Trying to address issue  #1182.

r? @fitzgen
@fitzgen fitzgen closed this as completed Dec 12, 2017
@fitzgen
Copy link
Member Author

fitzgen commented Dec 12, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned E-easy help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fitzgen @manaskarekar @highfive