dump_preprocessed_input test fails on Windows when checked out with CRLF line endings #1023
Labels
Comments
|
The reason this doesn't seem to be an issue with the rest of the tests is because rustfmt normalizes the line endings to LF when doing the comparison |
|
@highfive: assign me |
|
Hey @AndrewGaspar! Thanks for your interest in working on this issue. It's now assigned to you! |
bors-servo
pushed a commit
that referenced
this issue
Sep 25, 2017
…=fitzgen Always check out test headers and expectations as LF Addresses #1023. The line endings accidentally don't matter for the majority of the tests because we pass both the generated .rs files and expectations .rs files through rustfmt, which normalizes the line endings to LF. But this change makes it explicit that we expect to test against files with LF line endings.
|
FYI @AndrewGaspar, if you add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On Windows, typically users set the git
core.autocrlf=trueoption to checkout files with Windows-style line endings, but to checkin with Unix-style line endings.The dump_preprocessed_input test validates that an output file
__bindgen.iicontains an input filearg_keyword.hpp. However,__bindgen.iiis output with LF line endings, and so arg_keyword.hpp's contents do not match.I've validated the test passes if you check out the repo with LF line endings.
The text was updated successfully, but these errors were encountered: