This repository was archived by the owner on Sep 12, 2024. It is now read-only.
generated from rust-lang/project-group-template
-
Notifications
You must be signed in to change notification settings - Fork 18
misc-- oliver #21
Merged
Merged
misc-- oliver #21
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| https://github.com/rust-lang/rust/issues/34472 | ||
| https://github.com/rust-lang/rust/issues/36749 | ||
| https://github.com/rust-lang/rust/issues/37179 | ||
| https://github.com/rust-lang/rust/issues/43354 | ||
| https://github.com/rust-lang/rust/issues/37634 | ||
| https://github.com/rust-lang/rust/issues/37871 | ||
| https://github.com/rust-lang/rust/issues/41407 | ||
| https://github.com/rust-lang/rust/issues/42154 | ||
| https://github.com/rust-lang/rust/issues/51588 | ||
| https://github.com/rust-lang/rust/issues/30974 | ||
| https://github.com/rust-lang/rust/issues/49129 | ||
| https://github.com/rust-lang/rust/issues/54144 | ||
| https://github.com/rust-lang/rust/issues/51125 | ||
| https://github.com/rust-lang/rust/issues/54889 | ||
| https://github.com/rust-lang/rust/issues/40322 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| # PEH 2020-11-09 Meeting Agenda | ||
|
|
||
| ###### tags: `Error Handling` `Minutes` | ||
|
|
||
| - [2020-10-26 Meeting Minutes](https://hackmd.io/@rust-libs/rJ6aitNOw) | ||
|
|
||
| ## Action Items | ||
|
|
||
| - Implement trait based proof of concept for `Backtrace` in `core` (Jane Lusby) | ||
| - Update `object-provider` API in generic member access RFC (Jane Lusby) | ||
| - Move forward with adding an Error impl for `&impl Error` (Ashley Mannix) | ||
| - Create an FCP on the existing PR | ||
| - Add guidance for using &dyn Error + 'static and impl Error + Send + Sync + | ||
| 'static for borrow and owned errors respectively | ||
| - Review the "Fix the error trait" tracking issue to figure out next steps | ||
| (Oliver + Ashley Mannix) | ||
| - Review the panic plan rfc (Jane Lusby) | ||
| - reach out to the author of the error codes issue (Jane Lusby) | ||
| - Discuss universally consistent error reporting (Jane Lusby, Jakub Duchniewicz, | ||
| and Jeremiah Senkpiel) | ||
| - Post long term plan blog post (Sean Chean & Jane Lusby) | ||
| - Begin writing chapters for The Rust Error Book (unassigned) | ||
| - Resolve blockers in the backtrace stabilizition PR (Ashley Mannix) | ||
|
|
||
| ## Agenda Items | ||
|
|
||
| - Review action items from last meeting | ||
| - Review tracked issues in our [Project Board](https://github.com/rust-lang/project-error-handling/projects/1) | ||
| - [RFC#2580 related to 'Stabilizing `Error::type_id`'](https://hackmd.io/1Fq9TcAQRWa4_weWTe9adA) | ||
| - Anything to bubble up to the Libs meeting? | ||
| - Review `The Rust Error Book` looking to add initial content | ||
| - 2021 Rust Edition | ||
| - postponed? | ||
| - Discuss meeting time | ||
|
|
||
| # Meeting Minutes | ||
|
|
||
| Called to order at 13:00 PST | ||
|
|
||
| ## Attendees | ||
|
|
||
| - Jane Lusby | ||
| - Sean Chen | ||
| - Oliver | ||
| - Ashley Mannix | ||
| - Mara | ||
| - Jakub Duchniewicz | ||
| - DPC | ||
|
|
||
| ## Progress on Backtrace in Core [Jane Lusby] | ||
| - No progress on this since last time | ||
|
|
||
| ## Update Generic Member Access API [Jane Lusby] | ||
| - Reviewed changes made by Nika | ||
| - We should be using rustc errors as an example in the RFC | ||
| - Universal reporting is still messy and depends on features that don't exist | ||
| yet | ||
| - RFC for this is basically complete with some pending updates including | ||
| examples related to compiler error reporting | ||
|
|
||
| ## Adding an Error impl for `&impl Error` [Ashley Mannix] | ||
| - In final comment period. Will go in 1.49.0 when it's ready to go. | ||
| - starting patching for related libraries | ||
|
|
||
| ## Review the “Fix the error trait” tracking issue [Oliver + Ashley Mannix] | ||
| - No progress on this | ||
|
|
||
| ## Review the panic plan rfc [Jane Lusby] | ||
| - Now waiting for the FCP checkboxes; four more to go | ||
|
|
||
| ## Reach out to the author of the error codes issue [Jane Lusby] | ||
| - Didn't get to this | ||
|
|
||
| ## Post long term plan blog post [Sean Chean & Jane Lusby] | ||
| - Haven't put in suggested changes yet. | ||
|
|
||
| ## Begin writing chapters for The Rust Error Book [unassigned] | ||
| - Put out a call for a collection of references | ||
| - Are we targeting 2021 edition? | ||
| - Not particularly; shouldn't have any major breaking changes | ||
| - Besides unifying `panic`, shouldn't have anything that interacts with | ||
| editions | ||
| - Universal error reporting _might_ become something that involves requiring | ||
| a breaking change, but too nebulous to know at the moment | ||
|
|
||
|
|
||
| ## Resolve blockers in the backtrace stabilizition PR [Ashley Mannix] | ||
| - Different implementions for panics and errors since the panic backtrace | ||
| resolver can resolve frames in the presence of memory errors. | ||
| - Code between the two implementations can be shared, though this probably | ||
| doesn't have implications on the API. | ||
| - Unlisted concern in FCP | ||
| - Blocked on Amanieu having time to look through the recent discussion to | ||
| mark concern as resolved | ||
|
|
||
| ## Discuss universally consistent error reporting [Jane Lusby, Jakub Duchniewicz, and Jeremiah Senkpiel] | ||
| - Trying to find a way to introduce a "Reporter" that handles displaying `E: | ||
| Error` objects and additionally captures context relevant to those errors. | ||
| - Maybe extend this type to also handle `PanicInfo` objects | ||
| - Should naturally fit the design of the Error trait | ||
| - `PanicInfo` already has this handled by the hook from `set_hook` | ||
| - Unification will be a challenge | ||
|
|
||
| ## Backtrace Frames Method [Sean Chen] | ||
| - Started on this, though need to continue working through details from @KodrAus | ||
| - Suggestion to use a wrapper to return a borrow to data behind a `Mutex` | ||
| - @KodrAus -- for safety should materialize a `Vec` behind a wrapper | ||
| - additional suggestions forthcoming | ||
|
|
||
| ## Nicer Assert Messages [Charles Ellis O'Riley Jr.] | ||
| - Charles not in attendance today; punt this to next meeting | ||
|
|
||
| ## `PanicInfo::message` RFC [DPC] | ||
| - `de-vri-es` doing some work related to this | ||
| - Trying to add some kind of `AssertionInfo` to a `PanicInfo` that the test | ||
| crate can use to displays things more nicely without requiring support for | ||
| colors in std | ||
|
|
||
| ## `Error::type_id` [unassigned] | ||
| - Should enable a way to have function specialization such that `type_id` would | ||
| be specialized for every type | ||
| - Priority: low | ||
|
|
||
| ## Changing the Meeting Time going forward | ||
| - SIMD meeting starts right after this one | ||
| - Ideally, shift meeting back an hour for Daylight Savings and call it a day | ||
| - If not, might have to do another poll for meeting times | ||
| - Brought up in last week's SIMD meeting; didn't seem like anybody have issues | ||
| with shifting it | ||
|
|
||
| # Todo | ||
| ## Blog post coming soon | ||
| - goals to be run by project group before starting something on internals | ||
|
|
||
| ## Update Object Provider API [Jane Lusby] | ||
| - Add Nika's changes to RFC @2aetCAHHS5yPrDQIgqGo2Q | ||
|
|
||
| ## Adding an Error impl for `&impl Error` [Ashley Mannix] | ||
| - We can start patching libraries that it will break to get it ready for 1.49.0 | ||
| @KodrAus | ||
|
|
||
| ## Discuss universally consistent error reporting [Jane Lusby, Jakub Duchniewicz, and Jeremiah Senkpiel] | ||
| - Draft a blog post laying this out @2aetCAHHS5yPrDQIgqGo2Q | ||
|
|
||
| ## Review "The Rust Error Book" to add additional content | ||
| - Create an issue and gather existing resources to use as references for the | ||
| book @2aetCAHHS5yPrDQIgqGo2Q | ||
|
|
||
| ## Resolve blockers in the backtrace stabilizition PR [Ashley Mannix] | ||
| - Reach out to Amanieu to get their concerns resolved @KodrAus | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # PEH 2020-11-23 Meeting Agenda | ||
|
|
||
| ###### tags: `Error Handling` `Minutes` | ||
|
|
||
| - [2020-11-09 Meeting Minutes](https://hackmd.io/nWygbY49Rda-jXP4Qe1P8g) | ||
|
|
||
| ## Action Items | ||
|
|
||
| - Implement trait based proof of concept for `Backtrace` in `core` (Jane Lusby) | ||
| - Update `object-provider` API in generic member access RFC (Jane Lusby) | ||
| - Fix regressions caused by new impl error for `&'a E` change (unassigned) | ||
| - Review the "Fix the error trait" tracking issue to figure out next steps | ||
| (Oliver + Ashley Mannix) | ||
| - Review the panic plan rfc (Jane Lusby) | ||
| - reach out to the author of the error codes issue (Jane Lusby) | ||
| - Get long-term blog post posted on Inside Rust blog (Sean Chen) | ||
| - Resolve blockers in the backtrace stabilizition PR (Ashley Mannix) | ||
| - Follow up with Amanieu to mark concerns on backtrace stabilization as resolved | ||
| (Ashley Mannix) | ||
| - Create an issue and gather resources to use as reference material for the Rust | ||
| Error Book (Jane Lusby) | ||
| - Review open issues related to Error Handling and collate (Oliver) | ||
|
|
||
| ## Agenda Items | ||
|
|
||
| - Review action items from last meeting | ||
|
|
||
| # Attendees | ||
| - Sean Chen | ||
| - Jane Lusby | ||
| - oliver :snowman: | ||
| - Jeremiah Senkpiel | ||
| - simulacrum | ||
| - Ashley Mannix | ||
| - Charles Ellis O'Riley Jr. | ||
|
|
||
| # Meeting Minutes | ||
|
|
||
| - Work continues on nicer assert messages (Charles O.) | ||
| - [Stabilize the backtrace feature.](https://github.com/rust-lang/rust/pull/72981) (Jeremiah S. & Ashley M.) | ||
| - past final comments stage | ||
| - stabilization has been unblocked | ||
| - Blog Post (Sean C.) | ||
| - ready to merge! | ||
| - 'Fix the error trait' update (Oliver D. & Ashley M.) | ||
| - posted and edited the tracking and related issues on GH (Ashley M.) | ||
| - no forward momentum _but_ the activity on the issue was noticed and well | ||
| received by a decent number of accounts on GH | ||
| - next step is to push forward and continue capturing the attention of | ||
| possible contributors as is most appropriate | ||
| - currently no obvious blockers |
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaahc not seeing this in the past meeting notes or in this meetings minutes, Which issue is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may find some information here: https://blog.rust-lang.org/inside-rust/2020/11/23/What-the-error-handling-project-group-is-working-on.html#one-standardized-error-trait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@epage ping :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7