Skip to content

Support for building refactored libgit2 sources for vendored-libgit2 feature #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions libgit2-sys/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,21 @@ fn main() {
cp_r("libgit2/include", &include);

cfg.include(&include)
.include("libgit2/src")
.include("libgit2/src/libgit2")
.include("libgit2/src/util")
.out_dir(dst.join("build"))
.warnings(false);

// Include all cross-platform C files
add_c_files(&mut cfg, "libgit2/src");
add_c_files(&mut cfg, "libgit2/src/xdiff");
add_c_files(&mut cfg, "libgit2/src/libgit2");
add_c_files(&mut cfg, "libgit2/src/util");
add_c_files(&mut cfg, "libgit2/src/libgit2/xdiff");

// These are activated by features, but they're all unconditionally always
// compiled apparently and have internal #define's to make sure they're
// compiled correctly.
add_c_files(&mut cfg, "libgit2/src/transports");
add_c_files(&mut cfg, "libgit2/src/streams");
add_c_files(&mut cfg, "libgit2/src/libgit2/transports");
add_c_files(&mut cfg, "libgit2/src/libgit2/streams");

// Always use bundled http-parser for now
cfg.include("libgit2/deps/http-parser")
Expand Down Expand Up @@ -82,11 +84,11 @@ fn main() {
// when when COMPILE_PCRE8 is not defined, which is the default.
add_c_files(&mut cfg, "libgit2/deps/pcre");

cfg.file("libgit2/src/allocators/failalloc.c");
cfg.file("libgit2/src/allocators/stdalloc.c");
cfg.file("libgit2/src/util/allocators/failalloc.c");
cfg.file("libgit2/src/util/allocators/stdalloc.c");

if windows {
add_c_files(&mut cfg, "libgit2/src/win32");
add_c_files(&mut cfg, "libgit2/src/util/win32");
cfg.define("STRSAFE_NO_DEPRECATE", None);
cfg.define("WIN32", None);
cfg.define("_WIN32_WINNT", Some("0x0600"));
Expand All @@ -98,7 +100,7 @@ fn main() {
cfg.define("__USE_MINGW_ANSI_STDIO", "1");
}
} else {
add_c_files(&mut cfg, "libgit2/src/unix");
add_c_files(&mut cfg, "libgit2/src/util/unix");
cfg.flag("-fvisibility=hidden");
}
if target.contains("solaris") || target.contains("illumos") {
Expand Down Expand Up @@ -156,9 +158,9 @@ fn main() {
cfg.define("SHA1DC_NO_STANDARD_INCLUDES", "1");
cfg.define("SHA1DC_CUSTOM_INCLUDE_SHA1_C", "\"common.h\"");
cfg.define("SHA1DC_CUSTOM_INCLUDE_UBC_CHECK_C", "\"common.h\"");
cfg.file("libgit2/src/hash/sha1/collisiondetect.c");
cfg.file("libgit2/src/hash/sha1/sha1dc/sha1.c");
cfg.file("libgit2/src/hash/sha1/sha1dc/ubc_check.c");
cfg.file("libgit2/src/util/hash/sha1/collisiondetect.c");
cfg.file("libgit2/src/util/hash/sha1/sha1dc/sha1.c");
cfg.file("libgit2/src/util/hash/sha1/sha1dc/ubc_check.c");

if let Some(path) = env::var_os("DEP_Z_INCLUDE") {
cfg.include(path);
Expand Down Expand Up @@ -210,8 +212,12 @@ fn cp_r(from: impl AsRef<Path>, to: impl AsRef<Path>) {
}

fn add_c_files(build: &mut cc::Build, path: impl AsRef<Path>) {
let path = path.as_ref();
if !path.exists() {
panic!("Path {} does not exist", path.display());
}
// sort the C files to ensure a deterministic build for reproducible builds
let dir = path.as_ref().read_dir().unwrap();
let dir = path.read_dir().unwrap();
let mut paths = dir.collect::<io::Result<Vec<_>>>().unwrap();
paths.sort_by_key(|e| e.path());

Expand Down
2 changes: 1 addition & 1 deletion libgit2-sys/libgit2
Submodule libgit2 updated 886 files