-
Notifications
You must be signed in to change notification settings - Fork 413
add bindings for git_branch_name_is_valid
#715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
75bbdc8
to
c3f7460
Compare
c3f7460
to
ea3949a
Compare
Thanks! Is this an API though where the initialization function needs to be called first? If so this function may need to have a call to |
Hmm I'm new to libgit2 as well. But let me try to answer anyway: By looking at the function source code, it doesn't look like it needs any initialization: I'd say there's no need to call |
Ok! |
Is this function supposed to be present in libgit2 1.1.0? Because I'm getting linker errors while building the latest libgit2-sys / git2 crates (0.12.21+1.1.0 / 0.13.21) on Fedora (building against system libgit2):
|
No, libgit2-sys now needs latest master. That issue is tracked in #721. |
Hello! This is my first PR for Rust code. Feedback is greatly appreciated!
related: #714