Skip to content

feat: add git_submodule_clone #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 21, 2020
Merged

feat: add git_submodule_clone #611

merged 7 commits into from
Aug 21, 2020

Conversation

mainrs
Copy link
Contributor

@mainrs mainrs commented Aug 17, 2020

Closes #609

mainrs
mainrs commented Aug 17, 2020
View reviewed changes
@mainrs
Copy link
Contributor Author

mainrs commented Aug 17, 2020 •
edited
Loading

Not sure if this is a faulty implementation or not, but calling submodule.open() actually failed after I called this clone implementation. No error message, just () was displayed inside the stacktrace. The cloning did work though and all files where on my system.

ehuss
ehuss reviewed Aug 18, 2020
View reviewed changes
@mainrs
Copy link
Contributor Author

mainrs commented Aug 18, 2020

Thanks for taking the time to help me out @ehuss! :)

@mainrs mainrs marked this pull request as ready for review August 18, 2020 18:11
@ehuss ehuss merged commit 7aa5d85 into rust-lang:master Aug 21, 2020
@ehuss
Copy link
Contributor

ehuss commented Aug 21, 2020

Thanks!

@mainrs
Copy link
Contributor Author

mainrs commented Aug 21, 2020

Thank you for helping me out! :)

@mainrs mainrs deleted the impl_submodules branch August 21, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correctly working with submodules
2 participants
@mainrs @ehuss