Skip to content

work around for windows path separator for status_file #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2018
Merged

work around for windows path separator for status_file #341

merged 1 commit into from
Aug 2, 2018

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Aug 2, 2018

part of #340. Suggested by rust-lang/cargo#5820 (comment)

@alexcrichton
Copy link
Member

👍 Thanks!

bors referenced this pull request in rust-lang/cargo Aug 7, 2018
…hton

Improve verbose console and log for finding git repo in package check

Third attempt to resolve #5823 by improving logging and tests. This exposes the issue to testing,  via verbose console output and is dependent on alexcrichton/git2-rs#341 as just released in git2 0.7.5 crate. Thus tests *should* now pass on all platforms, incl. windows, but I also intend to bump the minimal git2 release dependency (in a subsequently added commit).

cc: @Eh2406 thanks for your fix and help!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants