Skip to content

Add support for push negotiation callback #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
martinvonz opened this issue Aug 4, 2021 · 0 comments · Fixed by #926
Closed

Add support for push negotiation callback #733

martinvonz opened this issue Aug 4, 2021 · 0 comments · Fixed by #926

Comments

@martinvonz
Copy link
Contributor

I'd like to implement something like git push --force-with-lease. libgit2/libgit2#4286 says that one can probably do that using the "push negotiation" callback, but it seems that git2-rs doesn't expose that yet.
martinvonz added a commit to jj-vcs/jj that referenced this issue Aug 5, 2021
@martinvonz
git: force push when not known to be a fast-forward
81ba65e 
With this change, we no longer fail if the user moves a branch
sideways or backwards and then push.

The push should ideally only succeed if the remote branch is where we
thought it was (like `git push --force-with-lease`), but that requires
rust-lang/git2-rs#733 to be fixed first.
@karin0 karin0 mentioned this issue Feb 1, 2023
Merged
@ehuss ehuss closed this as completed in #926 Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bindings for push_negotiation callback
1 participant
@martinvonz