Skip to content

Submodule::url panics #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mitsuhiko opened this issue Aug 28, 2018 · 2 comments
Closed

Submodule::url panics #348

mitsuhiko opened this issue Aug 28, 2018 · 2 comments

Comments

@mitsuhiko
Copy link

I have not found out why yet but we do a call to Submodule::url which is supposed to return an option but it panics unwrapping an internal option instead.

Apparently the return value of git_submodule_url is null which gets converted into None by opt_bytes and then unwrapped.

A stacktrace showing the issue can be seen here: getsentry/sentry-cli#361
@alexcrichton
Copy link
Member

Oh dear, seems bad! Should be fixed now though!

@alexcrichton
Copy link
Member

(fixed in alexcrichton@350da20)

alexcrichton added a commit that referenced this issue Aug 28, 2018
@alexcrichton
"Fix" the Submodule::url_bytes signature
350da20 
Apparently this can legitimately return a null pointer! We'll actually fix the
signature on the next major version bump

Closes #348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitsuhiko @alexcrichton