Fix help blurring whole page #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, yes this looks like the right fix. r? @GuillaumeGomez - I like this fix better than rust-lang/rust#77651, I had a feeling this was something on the docs.rs side. |
|
I'm fine with it too. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when pressing the
?key or the little?button next to the search bar that was recently added to rustdoc, the whole page is blurred. This makes the help unreadable.This is caused by doc.rs's "sandboxing"/"containerization" of rustdoc which messes up rustdoc's style. This was previously discussed in #52 and fixed in a8a3ece but a recent refactoring of the stylesheet in #943 messed up the fix.
From a cursory glance, it looks like all other changes in that PR were correct but the rule for
body.blurwas changed tobody { .blur { ... } }in SASS which gets translated tobody .blur(with a space in between, which has a different meaning).This PR fixes this problem by changing the rule to
body { &.blur { ... } }which SASS now again correctly translates tobody.blur { ... }, therefore restoring the correct behavior of the previous fix, causing only the background to be blurred again.