Pressing space to close a header menu (navigating with keyboard instead of mouse) will scroll down the page, not just close the menu

[jyn514]

Originally posted by @jyn514 in #1081 (comment)

[GuillaumeGomez]

It's not a bug. If you want an interaction with just the item and nothing else, you have the "enter" key. Space is supposed to scroll except when in a text field.

[jyn514]

@GuillaumeGomez space should either scroll or open the menu. It shouldn't do both.

[GuillaumeGomez]

I'd argue it definitely should. :p

[GuillaumeGomez]

Or more like: we shouldn't handle this ourselves.

[jyn514]

If you want to remove space handling and make it so you can only open the menu with enter, I'm fine with that. But the current behavior is not at all helpful or expected.

[GuillaumeGomez]

It's definitely expected. If I use space and I'm not in a text field, it's supposed to scroll down.

[notriddle]

It's not a bug. If you want an interaction with just the item and nothing else, you have the "enter" key. Space is supposed to scroll except when in a text field.

I've opened a pull request that traps the space key entirely. I'm willing to entertain the possibility of not handling the spacebar at all, too:

• The example set by WAI and by the menus on GitHub both trap space. I don't want to deviate from industry consensus without very good reason.

• Enter still acts as "link click" when the right-side drop down menus are selected.