Put it on a slip-n-slide

Author: Kixiron

src/db/add_package.rs

@@ -190,7 +190,10 @@ fn convert_dependencies(pkg: &MetadataPackage) -> Vec<(String, String, String)>
         .map(|dependency| {
             let name = dependency.name.clone();
             let version = dependency.req.clone();
-            let kind = dependency.kind.clone().unwrap_or_default();
+            let kind = dependency
+                .kind
+                .clone()
+                .unwrap_or_else(|| "normal".to_string());
 
             (name, version, kind)
         })

src/web/crate_details.rs

@@ -246,33 +246,33 @@ impl CrateDetails {
         let authors = conn
             .query(
                 "SELECT name, slug
-                                FROM authors
-                                INNER JOIN author_rels ON author_rels.aid = authors.id
-                                WHERE rid = $1",
+                 FROM authors
+                 INNER JOIN author_rels ON author_rels.aid = authors.id
+                 WHERE rid = $1",
                 &[&release_id],
             )
             .unwrap();
-        crate_details.authors.reserve(authors.len());
 
-        for row in &authors {
-            crate_details.authors.push((row.get(0), row.get(1)));
-        }
+        crate_details.authors = authors
+            .into_iter()
+            .map(|row| (row.get(0), row.get(1)))
+            .collect();
 
         // get owners
         let owners = conn
             .query(
                 "SELECT login, avatar
-             FROM owners
-             INNER JOIN owner_rels ON owner_rels.oid = owners.id
-             WHERE cid = $1",
+                 FROM owners
+                 INNER JOIN owner_rels ON owner_rels.oid = owners.id
+                 WHERE cid = $1",
                 &[&crate_id],
             )
             .unwrap();
-        crate_details.owners.reserve(owners.len());
 
-        for row in &owners {
-            crate_details.owners.push((row.get(0), row.get(1)));
-        }
+        crate_details.owners = owners
+            .into_iter()
+            .map(|row| (row.get(0), row.get(1)))
+            .collect();
 
         if !crate_details.build_status {
             crate_details.last_successful_build = crate_details

src/web/sitemap.rs

@@ -19,7 +19,8 @@ pub fn sitemap_handler(req: &mut Request) -> IronResult<Response> {
         )
         .unwrap();
 
-    let releases = query.into_iter()
+    let releases = query
+        .into_iter()
         .map(|row| {
             let time = format!("{}", time::at(row.get(1)).rfc3339());