Greasin' the wheels

Author: Kixiron

src/db/add_package.rs

@@ -190,7 +190,7 @@ fn convert_dependencies(pkg: &MetadataPackage) -> Vec<(String, String, String)>
         .map(|dependency| {
             let name = dependency.name.clone();
             let version = dependency.req.clone();
-            let kind = dependency.kind.clone().unwrap_or_else(|| "normal".into());
+            let kind = dependency.kind.clone().unwrap_or_default();
 
             (name, version, kind)
         })

src/docbuilder/crates.rs

@@ -12,7 +12,7 @@ where
     let reader = fs::File::open(path).map(BufReader::new)?;
 
     let mut name = String::new();
-    let mut versions = Vec::new(); // TODO: Find a way to pre-allocate the versions vector
+    let mut versions = Vec::new();
 
     for line in reader.lines() {
         // some crates have invalid UTF-8 (nanny-sys-0.0.7)

src/web/crate_details.rs

@@ -254,7 +254,7 @@ impl CrateDetails {
             .unwrap();
         crate_details.authors.reserve(authors.len());
 
-        for row in authors.iter() {
+        for row in &authors {
             crate_details.authors.push((row.get(0), row.get(1)));
         }
 
@@ -270,7 +270,7 @@ impl CrateDetails {
             .unwrap();
         crate_details.owners.reserve(owners.len());
 
-        for row in owners.iter() {
+        for row in &owners {
             crate_details.owners.push((row.get(0), row.get(1)));
         }
 

src/web/releases.rs

@@ -645,14 +645,14 @@ pub fn build_queue_handler(req: &mut Request) -> IronResult<Response> {
     let query = conn
         .query(
             "SELECT name, version, priority
-             FROM queue
-             WHERE attempt < 5
-             ORDER BY priority ASC, attempt ASC, id ASC",
+                          FROM queue
+                          WHERE attempt < 5
+                          ORDER BY priority ASC, attempt ASC, id ASC",
             &[],
         )
         .unwrap();
 
-    let crates = query
+    let crates: Vec<(String, String, i32)> = query
         .into_iter()
         .map(|krate| {
             (
@@ -664,7 +664,7 @@ pub fn build_queue_handler(req: &mut Request) -> IronResult<Response> {
                 -krate.get::<_, i32>("priority"),
             )
         })
-        .collect::<Vec<(String, String, i32)>>();
+        .collect();
 
     let is_empty = crates.is_empty();
     Page::new(crates)