Skip to content

Include global Ember CLI install in setup docs #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2014

Conversation

pimterry
Copy link
Contributor

@pimterry pimterry commented Dec 1, 2014

Tiny tweak; you need ember-cli installed globally to be able to run the site with the Ember command line runner, just npm install is not enough.

@killercup
Copy link
Member

I would very much prefer to instead tell people to use npm start -- --proxy https://staging-crates-io.herokuapp.com (requires npm >2.1 IIRC). This makes use of the already installed local dependency.

@pimterry
Copy link
Contributor Author

pimterry commented Dec 1, 2014

Interesting. NPM 2 is only relatively recent and is a major version bump, so I'm a little cautious about requiring it. It also seems slightly messy that anybody who wants to run a local UI has to specify the proxy themselves though, when that seems like a common case, and I think we can solve these both at once.

I've pushed a commit that adds a startui script to package.json, and updates these docs further to match. This can be run with npm run startui, which works fine in NPM < 2 (tested on 1.4.9, which happens to be what's installed on my work laptop) without global ember-cli, and starts up the server UI backed by the staging site. Anybody who does want to use a specific proxy can upgrade to NPM 2.0 and specify it by hand, but that seems like a far more niche case.

Does that sound reasonable?

@killercup
Copy link
Member

Sounds good. I guess that specific case (proxy to the staging system) is what most people who edit the UI want anyway.

@alexcrichton
Copy link
Member

Thanks @pimterry!

alexcrichton added a commit that referenced this pull request Dec 3, 2014
Include global Ember CLI install in setup docs
@alexcrichton alexcrichton merged commit 24662f9 into rust-lang:master Dec 3, 2014
@pimterry pimterry deleted the readme-tweaks branch December 3, 2014 10:58
Turbo87 pushed a commit to Turbo87/crates.io that referenced this pull request Jan 4, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants