Skip to content

Bump to alpha releases of conduit-* crates #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2020

Conversation

jtgeibel
Copy link
Member

@jtgeibel jtgeibel commented Feb 21, 2020

These upstream packages have been updated to prune old dependencies and
include no functional changes at this time. This PR removes 14
dependencies.

The updated version of civet is based on the 0.9 release we have been
pinned to. The 0.12 release abandons the attempts to update to the
underlying library which resulted in build failures on macOS for the
0.10 and 0.11 releases.

@rust-highfive
Copy link

r? @carols10cents

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Feb 23, 2020

☔ The latest upstream changes (presumably #2213) made this pull request unmergeable. Please resolve the merge conflicts.

@jtgeibel jtgeibel force-pushed the update/conduit-crates branch from e92e6ad to 198eead Compare February 24, 2020 03:08
@JohnTitor
Copy link
Member

Btw, this also looks good to me, feel free to r=me if you want.

@jtgeibel
Copy link
Member Author

@JohnTitor do you have macOS to confirm this builds/tests there? If not, hopefully @carols10cents can give it a quick test (although I'm pretty confident I dropped the problematic changes from upstream master).

Note to self: When deploying this to staging, I want to make sure I'm signed-in and then deploy. Then ensure the existing cookie can be read by cookie 0.12. Then test logout and login. I think breaking changes are unlikely here, but want to be safe when it comes to session management.

@JohnTitor
Copy link
Member

Ah, sorry I missed that! Let's wait then.

@bors
Copy link
Contributor

bors commented Feb 25, 2020

☔ The latest upstream changes (presumably #2216) made this pull request unmergeable. Please resolve the merge conflicts.

@jtgeibel jtgeibel force-pushed the update/conduit-crates branch from 198eead to 314cdd3 Compare February 25, 2020 03:36
@bors
Copy link
Contributor

bors commented Feb 29, 2020

☔ The latest upstream changes (presumably #2223) made this pull request unmergeable. Please resolve the merge conflicts.

@jtgeibel
Copy link
Member Author

@carols10cents can you verify this PR still builds for you on macOS? I don't expect any problems, but I want to verify before possibly breaking your build.

jtgeibel added 2 commits April 4, 2020 12:22
These upstream packages have been updated to prune old dependencies and
include no functional changes at this time.  This commit removes 12
dependencies.

The updated version of `civet` is based on the 0.9 release we have been
pinned to.  The 0.12 release abandons the attempts to update to the
underlying library which resulted in build failures on macOS for the
0.10 and 0.11 releases.
@jtgeibel jtgeibel force-pushed the update/conduit-crates branch from 314cdd3 to 996926b Compare April 4, 2020 16:23
@jtgeibel
Copy link
Member Author

jtgeibel commented Apr 4, 2020

I've rebased to resolve conflicts. I'm fairly confident I didn't break things on macOS and I'd like to drop these old dependencies so I'm going to merge.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 4, 2020

📌 Commit 996926b has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Apr 4, 2020

⌛ Testing commit 996926b with merge ca312fc...

@bors
Copy link
Contributor

bors commented Apr 4, 2020

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing ca312fc to master...

@bors bors merged commit ca312fc into rust-lang:master Apr 4, 2020
@jtgeibel jtgeibel deleted the update/conduit-crates branch May 11, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants