-
Notifications
You must be signed in to change notification settings - Fork 644
Bump to alpha releases of conduit-* crates #2208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #2213) made this pull request unmergeable. Please resolve the merge conflicts. |
e92e6ad
to
198eead
Compare
Btw, this also looks good to me, feel free to r=me if you want. |
@JohnTitor do you have macOS to confirm this builds/tests there? If not, hopefully @carols10cents can give it a quick test (although I'm pretty confident I dropped the problematic changes from upstream master). Note to self: When deploying this to staging, I want to make sure I'm signed-in and then deploy. Then ensure the existing cookie can be read by |
Ah, sorry I missed that! Let's wait then. |
☔ The latest upstream changes (presumably #2216) made this pull request unmergeable. Please resolve the merge conflicts. |
198eead
to
314cdd3
Compare
☔ The latest upstream changes (presumably #2223) made this pull request unmergeable. Please resolve the merge conflicts. |
@carols10cents can you verify this PR still builds for you on macOS? I don't expect any problems, but I want to verify before possibly breaking your build. |
These upstream packages have been updated to prune old dependencies and include no functional changes at this time. This commit removes 12 dependencies. The updated version of `civet` is based on the 0.9 release we have been pinned to. The 0.12 release abandons the attempts to update to the underlying library which resulted in build failures on macOS for the 0.10 and 0.11 releases.
314cdd3
to
996926b
Compare
I've rebased to resolve conflicts. I'm fairly confident I didn't break things on macOS and I'd like to drop these old dependencies so I'm going to merge. @bors r+ |
📌 Commit 996926b has been approved by |
☀️ Test successful - checks-travis |
These upstream packages have been updated to prune old dependencies and
include no functional changes at this time. This PR removes 14
dependencies.
The updated version of
civet
is based on the 0.9 release we have beenpinned to. The 0.12 release abandons the attempts to update to the
underlying library which resulted in build failures on macOS for the
0.10 and 0.11 releases.