Skip to content

Fix remaining Ember Data problem #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2015
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 16, 2015

Resolves the remaining issue in #214

@alexcrichton
Copy link
Member

You mention that this is because we're sending versions: null, but perhaps we could omit the versions key entirely when sending data? That should in theory have the same effect, right?

@Turbo87
Copy link
Member Author

Turbo87 commented Nov 16, 2015

That would probably have the same effect, yes. I don't have enough experience with the codebase yet to implement it there though. I would suggest to use the current solution for now and when we later refactor the api we can revisit this problem.

@alexcrichton
Copy link
Member

Hm I guess so, yeah, this may be a little tricky to implement. For now though it looks like the travis error is legit?

@Turbo87
Copy link
Member Author

Turbo87 commented Nov 16, 2015

ah shit, hadn't seen that one yet... I've been writing too much Kotlin lately 😉

This serializer will filter `versions: null` and remove it from the hash because in our case `null` means unknown instead of empty.
@Turbo87
Copy link
Member Author

Turbo87 commented Nov 16, 2015

should be fixed now

alexcrichton added a commit that referenced this pull request Nov 16, 2015
Fix remaining Ember Data problem
@alexcrichton alexcrichton merged commit 555a75b into rust-lang:master Nov 16, 2015
@alexcrichton
Copy link
Member

Thanks!

@alexcrichton
Copy link
Member

Ok, I've now deployed this, (thanks for all the fixes @Turbo87!)

One issue I see is that the "other downloads" section of the graphs isn't updated when you navigate between crates, for example if you click on the winapi crate and then on the libc crate you see this graph:

https://i.imgur.com/pBNlvn0.png

but if you reload the page you see:

https://i.imgur.com/eOV2SOL.png

@Turbo87
Copy link
Member Author

Turbo87 commented Nov 19, 2015

awesome! 🎉

I'll see what I can do about the remaining issue. There is also one more deprecation warning type that I have not fixed yet regarding request metadata. If that one is fixed we are on track to Ember v2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants