Skip to content

Filter crate dependencies by kind properly #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Mordorreal
Copy link

Add strict filtering by 'kind' field for crates.
Add separate section for Build dependencies.
Refactor crate deps filter functions.
Add tests for filters.

Fixes: #1641

Add strict filtering by 'kind' field for crates.
Add separate section for Build dependencies.
Refactor crate deps filter functions.
Add tests for filters.

Fixes: rust-lang#1641
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @smarnach (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@carols10cents
Copy link
Member

Looks great!!! Thank you so much!!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 13, 2019

📌 Commit acb62ac has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Dec 13, 2019

⌛ Testing commit acb62ac with merge 55fa81b...

bors added a commit that referenced this pull request Dec 13, 2019
…encies, r=carols10cents

Filter crate dependencies by kind properly

Add strict filtering by 'kind' field for crates.
Add separate section for Build dependencies.
Refactor crate deps filter functions.
Add tests for filters.

Fixes: #1641
@bors
Copy link
Contributor

bors commented Dec 13, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing 55fa81b to master...

@bors bors merged commit acb62ac into rust-lang:master Dec 13, 2019
@Mordorreal Mordorreal deleted the fix/display-regular-and-build-dependencies branch December 13, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display build-dependencies on crate page
6 participants