Skip to content

Bump backtrace and rustc-demangle #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

jtgeibel
Copy link
Member

@jtgeibel jtgeibel commented Oct 5, 2019

This commit bumps a few additional packages that could be related to
the segfaults seen in production. See #1805 for more info.

cargo update -p backtrace -p rustc-demangle

Updating backtrace v0.3.3 -> v0.3.38
Updating backtrace-sys v0.1.16 -> v0.1.31
Removing dbghelp-sys v0.2.0
Updating rustc-demangle v0.1.5 -> v0.1.16

This commit bumps a few additional packages that could be related to
the segfaults seen in production.  See rust-lang#1805 for more info.

`cargo update -p backtrace -p rustc-demangle`

```
Updating backtrace v0.3.3 -> v0.3.38
Updating backtrace-sys v0.1.16 -> v0.1.31
Removing dbghelp-sys v0.2.0
Updating rustc-demangle v0.1.5 -> v0.1.16
```
@rust-highfive
Copy link

r? @sgrif

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Contributor

@sgrif sgrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to deploy this in isolation since it's attempting to isolate segfaults

@carols10cents
Copy link
Member

@bors r+

I'm going to deploy this by itself and watch the logs this afternoon.

@bors
Copy link
Contributor

bors commented Nov 7, 2019

📌 Commit 460a4fa has been approved by carols10cents

@bors
Copy link
Contributor

bors commented Nov 7, 2019

⌛ Testing commit 460a4fa with merge 4be1f9f...

bors added a commit that referenced this pull request Nov 7, 2019
Bump `backtrace` and `rustc-demangle`

This commit bumps a few additional packages that could be related to
the segfaults seen in production.  See #1805 for more info.

`cargo update -p backtrace -p rustc-demangle`

```
Updating backtrace v0.3.3 -> v0.3.38
Updating backtrace-sys v0.1.16 -> v0.1.31
Removing dbghelp-sys v0.2.0
Updating rustc-demangle v0.1.5 -> v0.1.16
```
@bors
Copy link
Contributor

bors commented Nov 7, 2019

💔 Test failed - checks-travis

@carols10cents
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Nov 7, 2019

⌛ Testing commit 460a4fa with merge 0a6d3fb...

bors added a commit that referenced this pull request Nov 7, 2019
Bump `backtrace` and `rustc-demangle`

This commit bumps a few additional packages that could be related to
the segfaults seen in production.  See #1805 for more info.

`cargo update -p backtrace -p rustc-demangle`

```
Updating backtrace v0.3.3 -> v0.3.38
Updating backtrace-sys v0.1.16 -> v0.1.31
Removing dbghelp-sys v0.2.0
Updating rustc-demangle v0.1.5 -> v0.1.16
```
@bors
Copy link
Contributor

bors commented Nov 7, 2019

☀️ Test successful - checks-travis
Approved by: carols10cents
Pushing 0a6d3fb to master...

@bors bors merged commit 460a4fa into rust-lang:master Nov 7, 2019
@carols10cents
Copy link
Member

I'm not seeing any evidence of segfaults in production as a result of this PR.

@jtgeibel jtgeibel deleted the update/backtrace branch November 23, 2019 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants