Skip to content

Update to the latest comrak and ammonia for processing markdown #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

jtgeibel
Copy link
Member

The latest version of comrak requires an explicit opt-in to produce
unsanitized output (the previous default). We already sanitize the
output with ammonia and comrak's sanitized output is too
restrictive, causing 5 tests to fail.

Refs: #1265

The latest version of `comrak` requires an explicit opt-in to produce
unsanitized output (the previous default).  We already sanitize the
output with `ammonia` and `comrak`'s sanitized output is too
restrictive, causing 5 tests to fail.

Refs: rust-lang#1265
@sgrif
Copy link
Contributor

sgrif commented Mar 12, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 12, 2019

📌 Commit 6288d76 has been approved by sgrif

@bors
Copy link
Contributor

bors commented Mar 12, 2019

⌛ Testing commit 6288d76 with merge a620969...

bors added a commit that referenced this pull request Mar 12, 2019
Update to the latest `comrak` and `ammonia` for processing markdown

The latest version of `comrak` requires an explicit opt-in to produce
unsanitized output (the previous default).  We already sanitize the
output with `ammonia` and `comrak`'s sanitized output is too
restrictive, causing 5 tests to fail.

Refs: #1265
@bors
Copy link
Contributor

bors commented Mar 12, 2019

☀️ Test successful - checks-travis
Approved by: sgrif
Pushing a620969 to master...

@bors bors merged commit 6288d76 into rust-lang:master Mar 12, 2019
@jtgeibel jtgeibel deleted the update/comrak-and-ammonia branch July 14, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants