Skip to content

Migrate to using error-chain #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcrichton opened this issue Dec 3, 2014 · 5 comments
Closed

Migrate to using error-chain #88

alexcrichton opened this issue Dec 3, 2014 · 5 comments
Labels
C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Comments

@alexcrichton
Copy link
Member

This module should largely obsolete what we have in util::error
@carols10cents carols10cents added the C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear label Dec 15, 2016
@Eh2406
Copy link
Contributor

Eh2406 commented Feb 21, 2017

What is the best why to get started on this?

@alexcrichton
Copy link
Member Author

Oh dear this is quite an ancient bug! Nowaday's I'd recommend moving to error-chain, and that'd just start out by looking in src/util/errors.rs and migrating it all to error-chain's errors.

@Eh2406
Copy link
Contributor

Eh2406 commented Feb 22, 2017

I have not yet had the pleasure of using error-chain, so I am going to go do some reading.
Is there a way to do this cleanup incrementally? If it involves groking all error code in the project than re architecting the hole thing it may be more than I can do. If it can be done one piece at a time, it sounds more doable.

@alexcrichton
Copy link
Member Author

Unfortunately this is likely an "all at once transition" rather than a piecemeal one

@carols10cents carols10cents mentioned this issue Mar 18, 2017
Merged
@carols10cents carols10cents changed the title Migrate to using std::error Migrate to using error-chain May 12, 2017
@carols10cents
Copy link
Member

I don't think we're going to do this.

Turbo87 pushed a commit to Turbo87/crates.io that referenced this issue Jan 4, 2023
@renovate
Lock file maintenance (rust-lang#88)
66dba07 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @carols10cents @Eh2406