Skip to content

background-color not set when color is set #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mrmonday opened this issue Dec 19, 2015 · 2 comments
Closed

background-color not set when color is set #241

mrmonday opened this issue Dec 19, 2015 · 2 comments
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior

Comments

@mrmonday
Copy link

If the color property is set in CSS, the background-color property should also always be set, and vice versa. This is not currently true for crates.io, leading to situations like this:

2015-12-19-011737_501x102_scrot

Where the text is unreadable due to custom styles. See also, note 4 here: http://www.w3.org/TR/WCAG20/#contrast-ratiodef. There's probably a better/more direct link, I couldn't find it though, unfortunately.
@carols10cents carols10cents added A-ui C-bug 🐞 Category: unintended, undesired behavior labels Dec 15, 2016
@carols10cents carols10cents added this to the impl period milestone Sep 13, 2017
@carols10cents carols10cents removed this from the impl period milestone Sep 15, 2017
@esclear
Copy link

esclear commented Oct 1, 2017

This issue is probably resolved already.

In app.scss:136 a background color for the search is set.

Considering that the background pattern shall remain in the header, there is no background set for the header, just none for its children (the buttons).

And since a background-color is set for the #main-div that is inherited by all its children, it seems that all such cases are already accounted of.

@carols10cents
Copy link
Member

@esclear thank you for investigating this! Checking that it's indeed fixed is a huge help :) Closing!

bors added a commit that referenced this issue Dec 18, 2019
@bors
Auto merge of #1978 - rust-lang:dependabot/npm_and_yarn/ember-cli-bab…
f82b392 
…el-6.18.0, r=Turbo87

Bump ember-cli-babel from 6.14.1 to 6.18.0

Bumps [ember-cli-babel](https://github.com/babel/ember-cli-babel) from 6.14.1 to 6.18.0.
<details>
<summary>Changelog</summary>

*Sourced from [ember-cli-babel's changelog](https://github.com/babel/ember-cli-babel/blob/master/CHANGELOG.md).*

> ## v6.18.0 (2018-12-12)
>
> #### 🚀 Enhancement
> * [#257](https://github-redirect.dependabot.com/babel/ember-cli-babel/pull/257) Update babel-plugin-ember-modules-api-polyfill to 2.6.0. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### Committers: 1
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> ## v6.17.2 (2018-09-14)
>
> #### 🚀 Enhancement
> * [#244](https://github-redirect.dependabot.com/babel/ember-cli-babel/pull/244) Update to ember-rfc176-data@^0.3.5. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### Committers: 1
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> ## v6.17.0 (2018-08-27)
>
> #### 🐛 Bug Fix
> * [#241](https://github-redirect.dependabot.com/babel/ember-cli-babel/pull/241) Bumping broccoli-babel-transpiler to get the fix for parallelAPI ([@&#8203;arthirm](https://github.com/arthirm))
>
> #### Committers: 1
> - Arthi ([@&#8203;arthirm](https://github.com/arthirm))
>
>
> ## v6.16.0 (2018-07-18)
>
> #### 🚀 Enhancement
> * [#232](https://github-redirect.dependabot.com/babel/ember-cli-babel/pull/232) Upgrade deps ([@&#8203;stefanpenner](https://github.com/stefanpenner))
>
> #### Committers: 1
> - Stefan Penner ([@&#8203;stefanpenner](https://github.com/stefanpenner))
>
>
> ## v6.15.0 (2018-07-17)
>
> #### 🚀 Enhancement
> * [#230](https://github-redirect.dependabot.com/babel/ember-cli-babel/pull/230) update babel-plugin-debug-macros to 0.2.0-beta.6 ([@&#8203;kellyselden](https://github.com/kellyselden))
>
> #### 📝 Documentation
> * [#225](https://github-redirect.dependabot.com/babel/ember-cli-babel/pull/225) Update Changelog ([@&#8203;Turbo87](https://github.com/Turbo87))
>
> #### Committers: 2
> - Kelly Selden ([@&#8203;kellyselden](https://github.com/kellyselden))
> - Tobias Bieniek ([@&#8203;Turbo87](https://github.com/Turbo87))
</details>
<details>
<summary>Commits</summary>

- [`02b851b`](emberjs/ember-cli-babel@02b851b) 6.18.0
- [`724b372`](emberjs/ember-cli-babel@724b372) Merge pull request [#257](https://github-redirect.dependabot.com/babel/ember-cli-babel/issues/257) from rwjblue/update-modules-api-data
- [`d478fb5`](emberjs/ember-cli-babel@d478fb5) Update babel-plugin-ember-modules-api-polyfill to 2.6.0.
- [`29a94cd`](emberjs/ember-cli-babel@29a94cd) 6.17.1
- [`d9f55d6`](emberjs/ember-cli-babel@d9f55d6) Add v6.17.1 to CHANGELOG.
- [`8d9cd93`](emberjs/ember-cli-babel@8d9cd93) Update to ember-rfc176-data@^0.3.4.
- [`c58ae85`](emberjs/ember-cli-babel@c58ae85) 6.17.0
- [`5486b3e`](emberjs/ember-cli-babel@5486b3e) Add recent releases to changelog...
- [`ec3f25c`](emberjs/ember-cli-babel@ec3f25c) Merge pull request [#241](https://github-redirect.dependabot.com/babel/ember-cli-babel/issues/241) from arthirm/master
- [`af16202`](emberjs/ember-cli-babel@af16202) Bumping broccoli-babel-transpiler
- Additional commits viewable in [compare view](emberjs/ember-cli-babel@v6.14.1...v6.18.0)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-cli-babel&package-manager=npm_and_yarn&previous-version=6.14.1&new-version=6.18.0)](https://dependabot.com/compatibility-score.html?dependency-name=ember-cli-babel&package-manager=npm_and_yarn&previous-version=6.14.1&new-version=6.18.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the `.dependabot/config.yml` file in this repo:
- Update frequency
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Turbo87 @mrmonday @carols10cents @esclear