controllers/crate.version: Move documentationLink property to version model

Author: Turbo87

app/controllers/crate/version.js

@@ -123,27 +123,4 @@ export default class CrateVersionController extends Controller {
     return readme;
   })
   loadReadmeTask;
-
-  @computed('crate.{documentation,name}', 'currentVersion.{num,loadDocsBuildsTask.lastSuccessful.value}')
-  get documentationLink() {
-    // if this is *not* a docs.rs link we'll return it directly
-    if (this.crate.documentation && !this.crate.documentation.startsWith('https://docs.rs/')) {
-      return this.crate.documentation;
-    }
-
-    // if we know about a successful docs.rs build, we'll return a link to that
-    if (this.currentVersion.loadDocsBuildsTask.lastSuccessful) {
-      let docsBuilds = this.currentVersion.loadDocsBuildsTask.lastSuccessful.value;
-      if (docsBuilds.length !== 0 && docsBuilds[0].build_status === true) {
-        return `https://docs.rs/${this.crate.name}/${this.currentVersion.num}`;
-      }
-    }
-
-    // finally, we'll return the specified documentation link, whatever it is
-    if (this.crate.documentation) {
-      return this.crate.documentation;
-    }
-
-    return null;
-  }
 }

app/models/version.js

@@ -70,6 +70,29 @@ export default class Version extends Model {
   })
   loadDocsBuildsTask;
 
+  @computed('crate.{documentation,name}', 'num', 'loadDocsBuildsTask.lastSuccessful.value')
+  get documentationLink() {
+    // if this is *not* a docs.rs link we'll return it directly
+    if (this.crate.documentation && !this.crate.documentation.startsWith('https://docs.rs/')) {
+      return this.crate.documentation;
+    }
+
+    // if we know about a successful docs.rs build, we'll return a link to that
+    if (this.loadDocsBuildsTask.lastSuccessful) {
+      let docsBuilds = this.loadDocsBuildsTask.lastSuccessful.value;
+      if (docsBuilds.length !== 0 && docsBuilds[0].build_status === true) {
+        return `https://docs.rs/${this.crateName}/${this.num}`;
+      }
+    }
+
+    // finally, we'll return the specified documentation link, whatever it is
+    if (this.crate.documentation) {
+      return this.crate.documentation;
+    }
+
+    return null;
+  }
+
   @(task(function* () {
     let response = yield fetch(`/api/v1/crates/${this.crate.id}/${this.num}/yank`, { method: 'DELETE' });
     if (!response.ok) {

app/templates/crate/version.hbs

@@ -26,8 +26,8 @@
     {{#if this.crate.mailing_list}}
       <li><a href="{{this.crate.mailing_list}}">Mailing list</a></li>
     {{/if}}
-    {{#if this.documentationLink}}
-      <li><a href="{{this.documentationLink}}" data-test-docs-link>Documentation</a></li>
+    {{#if this.currentVersion.documentationLink}}
+      <li><a href="{{this.currentVersion.documentationLink}}" data-test-docs-link>Documentation</a></li>
     {{/if}}
     {{#if this.crate.repository}}
       <li><a href="{{this.crate.repository}}">Repository</a></li>