controllers/crate.version: Move loadDocsBuildsTask to version model

Author: Turbo87

app/controllers/crate/version.js

@@ -6,8 +6,6 @@ import { inject as service } from '@ember/service';
 import { task } from 'ember-concurrency';
 import moment from 'moment';
 
-import ajax from '../../utils/ajax';
-
 const NUM_VERSIONS = 5;
 
 export default class CrateVersionController extends Controller {
@@ -126,16 +124,16 @@ export default class CrateVersionController extends Controller {
   })
   loadReadmeTask;
 
-  @computed('crate.{documentation,name}', 'currentVersion.num', 'loadDocsBuildsTask.lastSuccessful.value')
+  @computed('crate.{documentation,name}', 'currentVersion.{num,loadDocsBuildsTask.lastSuccessful.value}')
   get documentationLink() {
     // if this is *not* a docs.rs link we'll return it directly
     if (this.crate.documentation && !this.crate.documentation.startsWith('https://docs.rs/')) {
       return this.crate.documentation;
     }
 
     // if we know about a successful docs.rs build, we'll return a link to that
-    if (this.loadDocsBuildsTask.lastSuccessful) {
-      let docsBuilds = this.loadDocsBuildsTask.lastSuccessful.value;
+    if (this.currentVersion.loadDocsBuildsTask.lastSuccessful) {
+      let docsBuilds = this.currentVersion.loadDocsBuildsTask.lastSuccessful.value;
       if (docsBuilds.length !== 0 && docsBuilds[0].build_status === true) {
         return `https://docs.rs/${this.crate.name}/${this.currentVersion.num}`;
       }
@@ -148,9 +146,4 @@ export default class CrateVersionController extends Controller {
 
     return null;
   }
-
-  @task(function* () {
-    return yield ajax(`https://docs.rs/crate/${this.crate.name}/${this.currentVersion.num}/builds.json`);
-  })
-  loadDocsBuildsTask;
 }

app/models/version.js

@@ -4,6 +4,8 @@ import { alias } from '@ember/object/computed';
 
 import { task } from 'ember-concurrency';
 
+import ajax from '../utils/ajax';
+
 export default class Version extends Model {
   @attr num;
   @attr dl_path;
@@ -63,6 +65,11 @@ export default class Version extends Model {
   }).keepLatest())
   loadReadmeTask;
 
+  @task(function* () {
+    return yield ajax(`https://docs.rs/crate/${this.crateName}/${this.num}/builds.json`);
+  })
+  loadDocsBuildsTask;
+
   @(task(function* () {
     let response = yield fetch(`/api/v1/crates/${this.crate.id}/${this.num}/yank`, { method: 'DELETE' });
     if (!response.ok) {

app/routes/crate/version.js

@@ -40,9 +40,9 @@ export default class VersionRoute extends Route {
       // ignored
     });
 
-    let { crate } = model;
+    let { crate, version } = model;
     if (!crate.documentation || crate.documentation.startsWith('https://docs.rs/')) {
-      controller.loadDocsBuildsTask.perform().catch(error => {
+      version.loadDocsBuildsTask.perform().catch(error => {
         // report unexpected errors to Sentry and ignore `ajax()` errors
         if (!(error instanceof AjaxError)) {
           Sentry.captureException(error);