cache Cargo artifacts #81
Conversation
notable changes in the docker-based testing infrastructure - the docker containers can now modify $CARGO_HOME, to re-use the outer Cargo registry, and the target directory to re-use build artifacts. - the docker containers are removed when their execution finishes because it's no longer necessary to re-start them to inspect them because all the interesting output is in the outer target directory
|
@homunkulus try |
cache Cargo artifacts notable changes in the docker-based testing infrastructure - the docker containers can now modify $CARGO_HOME, to re-use the outer Cargo registry, and the target directory to re-use build artifacts. - the docker containers are removed when their execution finishes because it's no longer necessary to re-start them to inspect them because all the interesting output is in the outer target directory r? @alexcrichton Let's see if this actually reduces test times ...
|
☀️ Test successful - status-appveyor, status-travis |
|
@homunkulus try |
cache Cargo artifacts notable changes in the docker-based testing infrastructure - the docker containers can now modify $CARGO_HOME, to re-use the outer Cargo registry, and the target directory to re-use build artifacts. - the docker containers are removed when their execution finishes because it's no longer necessary to re-start them to inspect them because all the interesting output is in the outer target directory r? @alexcrichton Let's see if this actually reduces test times ...
| -it $target \ | ||
| sh -c " | ||
| groupadd -g $gid $group | ||
| useradd -m -g $gid -u $uid $user |
There was a problem hiding this comment.
Have you tried the docker run --user argument for this? I've done --user $uid:$gid before and it's worked alright, just not great.
There was a problem hiding this comment.
I think this'd aovid the need for chown as well
There was a problem hiding this comment.
I didn't know that existed. I'll give it a try.
|
I've always been slightly wary of Docker volume sharing here, especially b/c the user/group never seem to quite match the way I want. If it works though and speeds things up though then sure! |
|
A single build job went from ~5m to ~2m 45s 🎉. |
|
💔 Test failed - status-travis |
| -v `rustc --print sysroot`:/rust:ro \ | ||
| -w /checkout \ | ||
| -it $target \ | ||
| sh -c "PATH=\$PATH:/rust/bin ci/run.sh $target" |
There was a problem hiding this comment.
This looks funny. Is there a way to extend PATH using the -e flag?
There was a problem hiding this comment.
Hm, maybe:
-e PATH=\$PATH:/rust/bin
I'm not sure if that works but if it doesn't my assumption would be no :(
There was a problem hiding this comment.
This results in PATH='$PATH:/rust/bin' with a literal $PATH in there 😆.
|
@homunkulus try |
cache Cargo artifacts notable changes in the docker-based testing infrastructure - the docker containers can now modify $CARGO_HOME, to re-use the outer Cargo registry, and the target directory to re-use build artifacts. - the docker containers are removed when their execution finishes because it's no longer necessary to re-start them to inspect them because all the interesting output is in the outer target directory r? @alexcrichton Let's see if this actually reduces test times ...
| sh ci/run-docker.sh $TARGET; | ||
| else | ||
| cargo test --target $TARGET && | ||
| cargo test --target $TARGET --release; | ||
| fi | ||
| # Travis can't cache files that are not readable by "others" | ||
| - chmod -R a+r $HOME/.cargo |
There was a problem hiding this comment.
Yes, in case we ever add a dependency that brings a file that doesn't have the o+r bit set. FWIW, I originally found this problem with the bitflags crate; its .gitignore was rwx------ iirc.
| @@ -45,13 +46,13 @@ install: | |||
| script: | |||
| - cargo generate-lockfile | |||
| - if [[ $TRAVIS_OS_NAME = "linux" ]]; then | |||
| sudo apt-get remove -y qemu-user-static && | |||
| sudo apt-get install -y qemu-user-static && | |||
There was a problem hiding this comment.
This was never needed AFAIK
|
☀️ Test successful - status-appveyor, status-travis |
81: implement log2 and log2f r=japaric a=erikdesjardins closes rust-lang#27, closes rust-lang#28 Co-authored-by: Erik <[email protected]>
notable changes in the docker-based testing infrastructure
Cargo registry, and the target directory to re-use build artifacts.
because it's no longer necessary to re-start them to inspect them
because all the interesting output is in the outer target directory
r? @alexcrichton
Let's see if this actually reduces test times ...