Skip to content

Rework the test crate to separate individual tests #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented May 18, 2024

Currently, tests of the same kind are grouped together across all types into a single function. This makes it difficult to understand exactly what failed in CI.

Change test macros to create separate functions for separate types so failures are more fine grained. Most existing functions become modules, then their individual calls to fuzz are split to functions.

@tgross35 tgross35 force-pushed the test-refactoring branch 6 times, most recently from 6adcd95 to cd27b21 Compare May 18, 2024 08:34
Currently, tests of the same kind are grouped together across all types
into a single function. This makes it difficult to understand exactly
what failed in CI.

Change test macros to create separate functions for separate types so
failures are more fine grained.
@tgross35 tgross35 force-pushed the test-refactoring branch from cd27b21 to 658cac7 Compare May 18, 2024 08:37
@tgross35 tgross35 marked this pull request as ready for review May 18, 2024 08:40
@tgross35
Copy link
Contributor Author

This conflicts with the other PRs I have open, but I can rebase in either direction depending on which lands first.

@Amanieu Amanieu merged commit b31d50e into rust-lang:master May 20, 2024
23 checks passed
@tgross35 tgross35 deleted the test-refactoring branch May 20, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants