Skip to content

Add tests for verbatim paths on windows builds #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 20, 2024
Merged

Add tests for verbatim paths on windows builds #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b0f1966
Add tests for UNC paths on windows builds
theKidOfArcrania May 15, 2024
853263a
Fix CI
theKidOfArcrania May 15, 2024
04c4866
Use cmd.exe
theKidOfArcrania May 15, 2024
73175bd
Fix backslash
theKidOfArcrania May 15, 2024
b8b09d5
Instead have cmd.exe dump out path
theKidOfArcrania May 15, 2024
ac30f02
Properly escape /C and fix naming
theKidOfArcrania May 15, 2024
e6ff35e
verbatim tests only need to build
theKidOfArcrania May 15, 2024
8fda434
Only run `--features c` for verbatim test
theKidOfArcrania May 17, 2024
12795d2
Don't run verbatim test on windows-gnu
theKidOfArcrania May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ jobs:
- target: aarch64-unknown-linux-gnu
os: ubuntu-latest
rust: nightly
- target: aarch64-pc-windows-msvc
os: windows-latest
rust: nightly
test_verbatim: 1
no_std: 1
- target: arm-unknown-linux-gnueabi
os: ubuntu-latest
rust: nightly
Expand Down Expand Up @@ -78,9 +83,11 @@ jobs:
- target: i686-pc-windows-msvc
os: windows-latest
rust: nightly
test_verbatim: 1
- target: x86_64-pc-windows-msvc
os: windows-latest
rust: nightly
test_verbatim: 1
- target: i686-pc-windows-gnu
os: windows-latest
rust: nightly-i686-gnu
Expand Down Expand Up @@ -109,6 +116,9 @@ jobs:
- run: ./ci/run.sh ${{ matrix.target }}
if: matrix.os != 'ubuntu-latest'
shell: bash
env:
NO_STD: ${{ matrix.no_std }}
TEST_VERBATIM: ${{ matrix.test_verbatim }}

# Otherwise we use our docker containers to run builds
- run: cargo generate-lockfile && ./ci/run-docker.sh ${{ matrix.target }}
Expand Down
5 changes: 5 additions & 0 deletions ci/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ else
$run --features no-f16-f128 --release
fi

if [ "${TEST_VERBATIM:-}" = "1" ]; then
verb_path=$(cmd.exe //C echo \\\\?\\%cd%\\testcrate\\target2)
cargo build --manifest-path testcrate/Cargo.toml --target $target --target-dir $verb_path --features c
fi

if [ -d /builtins-target ]; then
rlib_paths=/builtins-target/"${target}"/debug/deps/libcompiler_builtins-*.rlib
else
Expand Down