Add a Porting Reminders section to the README
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,19 @@ See [rust-lang/rust#35437][0]. | |||
| [2]: https://github.com/rust-lang/compiler-rt/tree/8598065bd965d9713bfafb6c1e766d63a7b17b89/lib/builtins | |||
| [3]: https://travis-ci.org/japaric/rustc-builtins | |||
|
|
|||
| ### Porting Reminders | |||
|
|
|||
| 1. [Rust][4] and [C][5] have slightly different operator precedence. | |||
There was a problem hiding this comment.
I wasn't aware. Could you cite a particular example here?
|
Thanks @mattico. Great initiative. I left some comments. r=me after those get addressed. |
mattico
force-pushed
the
add-readme-port-help
branch
from
64de9f8 to
549bc0b
Compare
|
Comments addressed. |
mattico
force-pushed
the
add-readme-port-help
branch
from
549bc0b to
3986d1e
Compare
|
Thank you, @mattico! |
tgross35
pushed a commit
to tgross35/compiler-builtins
that referenced
this pull request
Feb 23, 2025
108: coshf tanhf and atan2f r=japaric a=burrbull closes rust-lang#44 closes rust-lang#52 closes rust-lang#41 Co-authored-by: Andrey Zgarbul <[email protected]> Co-authored-by: Zgarbul Andrey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all pretty basic stuff, but it doesn't hurt to have a reminder (would've saved me some time ;) ).