Add public-test-deps feature for better visibility control #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jun 2, 2021
src/lib.rs
Outdated
| {$(#[$($meta:meta)*])* pub(crate) $ident:ident $($tokens:tt)*} => { | ||
| $(#[$($meta)*])* pub $ident $($tokens)* | ||
| }; | ||
| } |
There was a problem hiding this comment.
If you place the macros before the mod items, you shouldn't need #[macro_export] and use crate::public_test_dep.
There was a problem hiding this comment.
Thanks, I managed to remove all macros from the public interface. I'm pretty sure I tried this before and it wouldn't work, I must have had some detail wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #422.
Now, the only unwanted things in the public interface are some macros. This is unavoidable becauseThe public interface is finally fixed.#[macro_export]does not allow for fine grained control.