-
Notifications
You must be signed in to change notification settings - Fork 234
Add x86_64 builtins #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
use core::intrinsics; | ||
|
||
// NOTE These functions are implemented using assembly because they using a custom | ||
// calling convention which can't be implemented using a normal Rust function | ||
#[cfg(windows)] | ||
#[naked] | ||
#[cfg_attr(not(test), no_mangle)] | ||
pub unsafe fn ___chkstk_ms() { | ||
asm!("push %rcx | ||
push %rax | ||
cmp $$0x1000,%rax | ||
lea 24(%rsp),%rcx | ||
jb 1f | ||
2: | ||
sub $$0x1000,%rcx | ||
test %rcx,(%rcx) | ||
sub $$0x1000,%rax | ||
cmp $$0x1000,%rax | ||
ja 2b | ||
1: | ||
sub %rax,%rcx | ||
test %rcx,(%rcx) | ||
pop %rax | ||
pop %rcx | ||
ret"); | ||
intrinsics::unreachable(); | ||
} | ||
|
||
#[cfg(windows)] | ||
#[naked] | ||
#[cfg_attr(not(test), no_mangle)] | ||
pub unsafe fn __alloca() { | ||
asm!("mov %rcx,%rax // x64 _alloca is a normal function with parameter in rcx"); | ||
// The original behavior had __alloca fall through to ___chkstk here, but | ||
// I don't believe that this behavior is guaranteed, and a program that uses | ||
// only __alloca could have ___chkstk removed by --gc-sections. Call | ||
// ___chkstk here to guarantee that neither of those happen. | ||
___chkstk(); | ||
} | ||
|
||
#[cfg(windows)] | ||
#[naked] | ||
#[cfg_attr(not(test), no_mangle)] | ||
pub unsafe fn ___chkstk() { | ||
asm!("push %rcx | ||
cmp $$0x1000,%rax | ||
lea 16(%rsp),%rcx // rsp before calling this routine -> rcx | ||
jb 1f | ||
2: | ||
sub $$0x1000,%rcx | ||
test %rcx,(%rcx) | ||
sub $$0x1000,%rax | ||
cmp $$0x1000,%rax | ||
ja 2b | ||
1: | ||
sub %rax,%rcx | ||
test %rcx,(%rcx) | ||
|
||
lea 8(%rsp),%rax // load pointer to the return address into rax | ||
mov %rcx,%rsp // install the new top of stack pointer into rsp | ||
mov -8(%rax),%rcx // restore rcx | ||
push (%rax) // push return address onto the stack | ||
sub %rsp,%rax // restore the original value in rax | ||
ret"); | ||
intrinsics::unreachable(); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
__chkstk
uses a custom calling convention, you should probably jump to it using ajmp
instruction instead of calling it from Rust.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had thought about that, but couldn't
__chkstk
possibly be removed by the linker in that case? Now that I think about it again, the linker could probably see the use of the___chkstk
symbol in thejmp
and leave it in, just the same as it would for acall
instruction.