Skip to content

Add x86_64 builtins #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2016
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ extern crate rlibc;
#[cfg(target_arch = "arm")]
pub mod arm;

#[cfg(target_arch = "x86_64")]
pub mod x86_64;

pub mod udiv;
pub mod mul;
pub mod shift;
Expand Down
67 changes: 67 additions & 0 deletions src/x86_64.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
use core::intrinsics;

// NOTE These functions are implemented using assembly because they using a custom
// calling convention which can't be implemented using a normal Rust function
#[cfg(windows)]
#[naked]
#[cfg_attr(not(test), no_mangle)]
pub unsafe fn ___chkstk_ms() {
asm!("push %rcx
push %rax
cmp $$0x1000,%rax
lea 24(%rsp),%rcx
jb 1f
2:
sub $$0x1000,%rcx
test %rcx,(%rcx)
sub $$0x1000,%rax
cmp $$0x1000,%rax
ja 2b
1:
sub %rax,%rcx
test %rcx,(%rcx)
pop %rax
pop %rcx
ret");
intrinsics::unreachable();
}

#[cfg(windows)]
#[naked]
#[cfg_attr(not(test), no_mangle)]
pub unsafe fn __alloca() {
asm!("mov %rcx,%rax // x64 _alloca is a normal function with parameter in rcx");
// The original behavior had __alloca fall through to ___chkstk here, but
// I don't believe that this behavior is guaranteed, and a program that uses
// only __alloca could have ___chkstk removed by --gc-sections. Call
// ___chkstk here to guarantee that neither of those happen.
___chkstk();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since __chkstk uses a custom calling convention, you should probably jump to it using a jmp instruction instead of calling it from Rust.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had thought about that, but couldn't __chkstk possibly be removed by the linker in that case? Now that I think about it again, the linker could probably see the use of the ___chkstk symbol in the jmp and leave it in, just the same as it would for a call instruction.

}

#[cfg(windows)]
#[naked]
#[cfg_attr(not(test), no_mangle)]
pub unsafe fn ___chkstk() {
asm!("push %rcx
cmp $$0x1000,%rax
lea 16(%rsp),%rcx // rsp before calling this routine -> rcx
jb 1f
2:
sub $$0x1000,%rcx
test %rcx,(%rcx)
sub $$0x1000,%rax
cmp $$0x1000,%rax
ja 2b
1:
sub %rax,%rcx
test %rcx,(%rcx)

lea 8(%rsp),%rax // load pointer to the return address into rax
mov %rcx,%rsp // install the new top of stack pointer into rsp
mov -8(%rax),%rcx // restore rcx
push (%rax) // push return address onto the stack
sub %rsp,%rax // restore the original value in rax
ret");
intrinsics::unreachable();
}