Skip to content

Attempt to fix TravisCI #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2018
Merged

Conversation

paoloteti
Copy link
Contributor

@paoloteti paoloteti commented Sep 14, 2018

  • Set DEBUG_LTO_BUILD_DOESNT_WORK for i686-apple-darwin and x86_64-apple-darwin to avoid the undefined reference problem with debug-assertions+lto

  • Remove #[panic_handler] attribute since this feature is now stable

Fixes the following warning:

"warning: the feature `panic_handler` has been stable since
1.30.0 and no longer requires an attribute to enable"
Temporary workaround for the well known
"undefined references problem for debug-assertions+lto" (rust-lang#79)
@alexcrichton
Copy link
Member

Awesome, thanks! Progress being made works for me :)

Looks like Windows may still have issues, but that's fine to fix at a future time.

@alexcrichton alexcrichton merged commit a50c848 into rust-lang:master Sep 14, 2018
@paoloteti paoloteti deleted the fix-travis-ci branch September 14, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants