Add ledf2vfp/leds2vfp, add test cases for __unordsf2/__unorddf2 and re-enable thumb* targets
#233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `73884ae` is in some nightly release We can add ledf2vfp/leds2vfp and so these two functions be aliased to aeabi_fcmple/aeabi_dcmple on soft-float targets.
|
Thanks! |
tgross35
pushed a commit
to tgross35/compiler-builtins
that referenced
this pull request
Feb 23, 2025
A mistake was made in porting musl's implementation which caused the sin and cos components to be reversed. closes rust-lang#232
tgross35
pushed a commit
that referenced
this pull request
Apr 18, 2025
A mistake was made in porting musl's implementation which caused the sin and cos components to be reversed. closes rust-lang/libm#232
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a collection of minor changes:
Now that
73884aeis in some nightly release We can addledf2vfp/leds2vfpand so these two functions can be aliased toaeabi_fcmple/aeabi_dcmpleon soft-float targets.Add missing test cases for
__unordsf2/__unorddf2Remove
allow_failuresfor thumb* targets