-
Notifications
You must be signed in to change notification settings - Fork 230
Fix CI for thumb* targets #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
280012b
7f92a8e
8289e62
8661273
7b81af0
9e99aa2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,12 +14,15 @@ rand = { version = "0.4", features = ["i128_support"] } | |
[dependencies.compiler_builtins] | ||
path = ".." | ||
default-features = false | ||
features = ["mangled-names", "no-lang-items"] | ||
features = ["no-lang-items"] | ||
|
||
[target.'cfg(all(target_arch = "arm", not(any(target_env = "gnu", target_env = "musl")), target_os = "linux"))'.dev-dependencies] | ||
test = { git = "https://github.com/japaric/utest" } | ||
utest-cortex-m-qemu = { default-features = false, git = "https://github.com/japaric/utest" } | ||
utest-macros = { git = "https://github.com/japaric/utest" } | ||
test = { git = "https://github.com/paoloteti/utest", branch = "ci" } | ||
utest-cortex-m-qemu = { default-features = false, git = "https://github.com/paoloteti/utest", branch = "ci" } | ||
utest-macros = { git = "https://github.com/paoloteti/utest", branch = "ci" } | ||
|
||
[features] | ||
c = ["compiler_builtins/c"] | ||
mem = ["compiler_builtins/mem"] | ||
mangled-names = ["compiler_builtins/mangled-names"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could this perhaps be turned on by default? I was hoping to keep There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you mean 'default = ["mangled-names"]' only ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indeed! |
||
no_std = [] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
#![cfg_attr(feature = "no_std", no_std)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could this unconditionally be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (or this entire file could be emptied) |
||
|
||
#[cfg(test)] | ||
mod tests { | ||
#[test] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,35 @@ | ||
#![feature(compiler_builtins_lib)] | ||
#![feature(i128_type)] | ||
#![feature(lang_items, core_float, core_float_bits)] | ||
#![allow(bad_style)] | ||
#![allow(unused_imports)] | ||
#![no_std] | ||
|
||
use core::num::Float; | ||
|
||
extern crate compiler_builtins; | ||
|
||
#[cfg(all(target_arch = "arm", | ||
not(any(target_env = "gnu", target_env = "musl")), | ||
target_os = "linux", | ||
test))] | ||
extern crate utest_cortex_m_qemu; | ||
|
||
#[cfg(all(target_arch = "arm", | ||
not(any(target_env = "gnu", target_env = "musl")), | ||
target_os = "linux", | ||
test))] | ||
#[macro_use] | ||
extern crate utest_macros; | ||
|
||
#[cfg(all(target_arch = "arm", | ||
not(any(target_env = "gnu", target_env = "musl")), | ||
target_os = "linux", | ||
test))] | ||
macro_rules! panic { // overrides `panic!` | ||
($($tt:tt)*) => { | ||
upanic!($($tt)*); | ||
}; | ||
} | ||
|
||
include!(concat!(env!("OUT_DIR"), "/generated.rs")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For tracking purposes, are the changes here available as upstream PRs perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is upstream now, I'll update the URL