-
Notifications
You must be signed in to change notification settings - Fork 234
i128 intrinsics #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
i128 intrinsics #133
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a2e2ec1
Add i128 to lib.rs as feature
est31 b356429
int module: macro-ify trait impls and add {u,i}128 support
est31 3055aa2
i128 mul intrinsics
est31 1e27c3f
i128 shift intrinsics
est31 8fe50d8
Macro-ify udivmod
est31 2f3c534
u128 udiv intrinsics
est31 9013dbe
u128 sdiv intrinsics
est31 417b07b
Add newly implemented intrinsics to test file
est31 b78e956
Add quickcheck tests
est31 f8a4e3f
Panic when invalid overflow value is returned
est31 37d3490
Disable quickcheck tests on mips
est31 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -380,3 +380,48 @@ mod tests { | |
} | ||
} | ||
} | ||
|
||
#[cfg(test)] | ||
#[cfg(all(not(windows), target_pointer_width="64"))] | ||
mod tests_i128 { | ||
use qc::U128; | ||
|
||
check! { | ||
fn __udivti3(f: extern fn(u128, u128) -> u128, | ||
n: U128, | ||
d: U128) -> Option<u128> { | ||
let (n, d) = (n.0, d.0); | ||
if d == 0 { | ||
None | ||
} else { | ||
Some(f(n, d)) | ||
} | ||
} | ||
|
||
fn __umodti3(f: extern fn(u128, u128) -> u128, | ||
n: U128, | ||
d: U128) -> Option<u128> { | ||
let (n, d) = (n.0, d.0); | ||
if d == 0 { | ||
None | ||
} else { | ||
Some(f(n, d)) | ||
} | ||
} | ||
|
||
fn __udivmodti4(f: extern fn(u128, u128, Option<&mut u128>) -> u128, | ||
n: U128, | ||
d: U128) -> Option<u128> { | ||
let (n, d) = (n.0, d.0); | ||
if d == 0 { | ||
None | ||
} else { | ||
// FIXME fix the segfault when the remainder is requested | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you open an issue about this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure! |
||
/*let mut r = 0; | ||
let q = f(n, d, Some(&mut r)); | ||
Some((q, r))*/ | ||
Some(f(n, d, None)) | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't a value different that 0 or 1 indicate a bug in our implementation? I think such case should panic instead of being skipped.