Skip to content

CI: use a recent nightly #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 31, 2016
Merged

CI: use a recent nightly #131

merged 2 commits into from
Dec 31, 2016

Conversation

japaric
Copy link
Member

@japaric japaric commented Dec 31, 2016

  • add #[no_mangle] to the panic_fmt lang item to adjust to changes in
    the visibility algorithm

  • adjust to changes in the layout of Cargo's target directory

  • use a newer Xargo to reduce the build time of the sysroot (only core
    is compiled as part of the sysroot now)

r? @alexcrichton

Jorge Aparicio added 2 commits December 31, 2016 10:04
- add #[no_mangle] to the panic_fmt lang item to adjust to changes in
the visibility algorithm

- adjust to changes in the layout of Cargo's target directory

- use a newer Xargo to reduce the build time of the sysroot (only core
is compiled as part of the sysroot now)
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 31, 2016

📌 Commit 53da94d has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 31, 2016

⌛ Testing commit 53da94d with merge 0fd5e75...

bors added a commit that referenced this pull request Dec 31, 2016
CI: use a recent nightly

- add #[no_mangle] to the panic_fmt lang item to adjust to changes in
the visibility algorithm

- adjust to changes in the layout of Cargo's target directory

- use a newer Xargo to reduce the build time of the sysroot (only core
is compiled as part of the sysroot now)

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Dec 31, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 0fd5e75 to master...

@bors bors merged commit 53da94d into rust-lang:master Dec 31, 2016
@japaric japaric deleted the rustup branch December 31, 2016 19:51
tgross35 pushed a commit to tgross35/compiler-builtins that referenced this pull request Feb 23, 2025
131: omit bounds check in release mode r=japaric a=japaric

this eliminates panicking branches in the optimized version of the functions. We keep the bounds
checks when running the test suite to check that we never do an out of bounds access.

This commit also adds a "must link" test that ensures that future changes in our implementation
won't add panicking branches.

closes rust-lang#129

Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants