Skip to content

by default, mark this crate as the #![compiler_builtins] crate #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2016

Conversation

japaric
Copy link
Member

@japaric japaric commented Dec 10, 2016

as this is how most users will want to use this crate

r? @alexcrichton

@alexcrichton
Copy link
Member

Hm this isn't actually used as #[cfg(feature = "rustbuild")] in the source, is that intentional?

@japaric
Copy link
Member Author

japaric commented Dec 11, 2016

Nah, it was wrong to begin with. I also need to update ci/run.sh to not use #![compiler_builtins] during tests. I'll update the PR once #125 lands.

as this is how most users will want to use this crate
@japaric japaric changed the title add the rustbuild feature by default, mark this crate as the #![compiler_builtins] crate Dec 11, 2016
@japaric
Copy link
Member Author

japaric commented Dec 11, 2016

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 12, 2016

📌 Commit b59c789 has been approved by alexcrichton

bors added a commit that referenced this pull request Dec 12, 2016
by default, mark this crate as the #![compiler_builtins] crate

as this is how most users will want to use this crate

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Dec 12, 2016

⌛ Testing commit b59c789 with merge 70009a3...

@bors
Copy link
Contributor

bors commented Dec 13, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 70009a3 to master...

@bors bors merged commit b59c789 into rust-lang:master Dec 13, 2016
tgross35 pushed a commit to tgross35/compiler-builtins that referenced this pull request Feb 23, 2025
126: implement pow r=japaric a=japaric

cargo fmt version of rust-lang#125 
closes rust-lang#125 
closes rust-lang#124

Co-authored-by: Rahul Butani <[email protected]>
Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants